This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
✨ Cleanups after removing BundleAPI #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 35.27% 35.27%
=======================================
Files 9 9
Lines 808 808
=======================================
Hits 285 285
Misses 479 479
Partials 44 44 ☔ View full report in Codecov by Sentry. |
varshaprasad96
force-pushed
the
followup-fix-conditions
branch
2 times, most recently
from
22e60eb to
120aca1
Compare
joelanford
reviewed
Jan 22, 2024
varshaprasad96
force-pushed
the
followup-fix-conditions
branch
2 times, most recently
from
d540eb9 to
aa3ce96
Compare
This PR makes the follwing changes: 1. Fixes the reference to v1alpha1 APIs in the linter. 2. TypeHasValidBundle was being set to false only when the bundle load errored. Switching the condition to be TypeInstalled instead. 3. Fix documentation on provisioners. Signed-off-by: Varsha Prasad Narsing <[email protected]>
varshaprasad96
force-pushed
the
followup-fix-conditions
branch
from
aa3ce96 to
35808e0
Compare
|
This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the |
github-actions
bot
added
the
lifecycle/stale
|
This PR has been closed as no updates were detected after 30 days of being stale. Please feel free to reopen this PR if necessary. |
github-actions
bot
added
the
lifecycle/rotten
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the follwing changes:
Follow up #774