Improve cluster autoscaler docs & improve eviction-grace-period computation #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
… permit node draining on delete
robo-cap
changed the title
robo-cap
changed the title
robo-cap
changed the title
devoncrouse
approved these changes
Sep 21, 2023
devoncrouse
pushed a commit
to devoncrouse/terraform-oci-oke
that referenced
this pull request
Oct 11, 2023
…tation (oracle-terraform-modules#829) * fix issues with the cluster_autoscaler defined_tags for worker nodes * improve cluster autoscaler documentation * improve eviction_grate_duration computation & change default value to permit node draining on delete
devoncrouse
pushed a commit
that referenced
this pull request
Oct 11, 2023
…tation (#829) * fix issues with the cluster_autoscaler defined_tags for worker nodes * improve cluster autoscaler documentation * improve eviction_grate_duration computation & change default value to permit node draining on delete
devoncrouse
pushed a commit
that referenced
this pull request
Oct 11, 2023
…tation (#829) * fix issues with the cluster_autoscaler defined_tags for worker nodes * improve cluster autoscaler documentation * improve eviction_grate_duration computation & change default value to permit node draining on delete
hyder
pushed a commit
that referenced
this pull request
Oct 25, 2023
…tation (#829) * fix issues with the cluster_autoscaler defined_tags for worker nodes * improve cluster autoscaler documentation * improve eviction_grate_duration computation & change default value to permit node draining on delete
thpham
pushed a commit
to thpham/terraform-oci-oke
that referenced
this pull request
Nov 24, 2023
…tation (oracle-terraform-modules#829) * fix issues with the cluster_autoscaler defined_tags for worker nodes * improve cluster autoscaler documentation * improve eviction_grate_duration computation & change default value to permit node draining on delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster autoscaler documentation was updated in response to #809.
When the
eviction_grace_periodis set to 0, the delete operation of worker nodes from the node pool controller doesn't wait for thecordonanddrainoperations to finalize.By changing the default value of this parameter to 300 seconds we provide a grace period for node draining operation reducing the risk of service impact.
As the expected format for the nodepool
eviction_grace_periodattribute isPTxMyS, the new computation method will prevent deviations from how this parameter is set in TF and how it's returned by the API after theterraform applycommand when values than 60 are configured.