Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svm: fix for JDK 21.0.4 after the downport of "8315373: Change VirtualThread to unmount after freezing, re-mount before thawing" and dependnet changes #8562

Closed

Conversation

simonis
Copy link
Contributor

@simonis simonis commented Mar 13, 2024

This change fixes svm after the downport of JDK-8315373 (which included JDK-8312498, JDK-8312777, JDK-8321270, JDK-8322818, JDK-8323002, JDK-8323296, JDK-8316924) to OpenJDK 21.0.4. It does this by downporting

and adopting them to work on JDK 21.

I'm not sure if this fix should be done in this repository or in the master branch of the graalvm/graalvm-for-jdk21-community-backports repository which currently matches the release/graal-vm/23.1 branch of this repository. I don't understand how these two branches/repositories are related, if one is synced into the other automatically or if one of them is abandoned. For any case I've also submitted this PR to graalvm/graalvm-for-jdk21-community-backports as well (see PR). Feel free to close one of them but please be so kind and explain the relationship of the two branches/repositories :)

zapster and others added 4 commits March 12, 2024 18:45
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@simonis
Copy link
Contributor Author

simonis commented Mar 13, 2024

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:

* PR author: [[email protected]](mailto:[email protected]) (@simonis)

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

Please note that I'm an OpenJDK Contributor already ('simonis' in the OpenJDK Census and member of the OpenJDK Github organization). I've already personally signed the Sun Contributor Agreement but am also covered by Amazon's company-wide OCA. Please let me know if there's anything else I have to do?

@fniephaus fniephaus requested a review from peter-hofer March 13, 2024 11:12
@fniephaus fniephaus self-assigned this Mar 13, 2024
@ezzarghili
Copy link
Member

ezzarghili commented Mar 13, 2024

Feel free to close one of them but please be so kind and explain the relationship of the two branches/repositories

graalvm/graalvm-for-jdk21-community-backports graalvm/graalvm-for-jdk17-community-backports were created based on discussions in the GraalVM Meetup with the contributors' community, we no longer provide community builds for JDK 17 and JDK 21, those repos are where we share the open parts of GraalVM for the community (i.e mandrel) that wishes to still continue providing builds for them, we also use those repos for getting backport requests .

Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Mar 13, 2024
@simonis
Copy link
Contributor Author

simonis commented Mar 13, 2024

Feel free to close one of them but please be so kind and explain the relationship of the two branches/repositories

graalvm/graalvm-for-jdk21-community-backports graalvm/graalvm-for-jdk17-community-backports were created based on discussions in the GraalVM Meetup with the contributors' community, we no longer provide community builds for JDK 17 and JDK 21, those repos are where we share the open parts of GraalVM for the community (i.e mandrel) that wishes to still continue providing builds for them, we also use those repos for getting backport requests .

@ezzarghili thank you for this information. So based on what you are saying, I should close this PR and follow up on the PR in the graalvm/graalvm-for-jdk21-community-backports repository, right?

You also say that "you no longer provide community builds for JDK 17 and JDK 21" but I was a little confused why you've then still downported 219 changes after the release of graal-23.1.2 to the release/graal-vm/23.1 branch (with the last change being donwported just last week) apparently in the preparation of the GraalVM 23.1.3 release as the "New dev cycle GraalVM 23.1.3" commit indicates? So after all, will there be a final 23.1.3 release/tag in this repository or not? This obviously doesn't necessarily mean that you also have to provide a community build for that tag.

The other question would be who is in charge of graalvm/graalvm-for-jdk21-community-backports? I.e. who has the right to review and approve pull requests? Bacause in contrast to this PR, I haven't got any reaction on my other PR in graalvm/graalvm-for-jdk21-community-backports until now.

@fniephaus
Copy link
Member

Hi Volker, thanks a lot for the downport! As @ezzarghili mentioned, we are using the new repositories for community backports, so I will close this PR for now.

Also, apologies for the slow response. I self-assigned this when I saw it three days ago and requested a review. I then de-prioritized this because we are getting very close to the release of GraalVM for JDK 22. That, and the fact that this is one of the first community backport requests, are why we haven't had time to answer your related questions. Let's keep the PRs technical and continue the general discussion about backports on Slack (I see you've posted there as well).

@fniephaus fniephaus closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants