-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promoted File#path to IO#path, added path: optional param to IO#new #3275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
You need to untag the spec for this with jt untag spec/ruby/core/io/path_spec.rb
.
It makes sense to declare in this PR a |
You mean in IO ? File already declares a to_path using alias_method |
175a645
to
53dc421
Compare
Yes, I mean in f = File.new("a.txt", "w")
f.method(:path).owner
#=> IO
f.method(:to_path).owner
#=> IO |
53dc421
to
958aa07
Compare
Could you please rename the commit, e.g. name it similar to the PR title? |
958aa07
to
f1a6eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits and ready to go
Could also add a changelog entry? See https://github.com/oracle/truffleruby/blob/master/CONTRIBUTING.md#changelog |
30cf696
to
328f508
Compare
Could you please squash working commits? Removing exception classes might deserve a separate commit. |
ea41c29
to
03fedec
Compare
…ath: optional param to IO#new
03fedec
to
8389acd
Compare
Implementing feature Feature #19036] in Ruby 3.2 compatibility.