Code

Some suggestions#1

Code

Open

ekes wants to merge 15 commits intoorphans:developorphans/commerce_sagepay:developfrom ekes:developekes/commerce_sagepay:developCopy head branch name to clipboard

+5,238-5,105

Commits

Commits on Mar 9, 2022

• Don't throw fatal error if line item doesn't have a product item.

  ekes

  committed
  7da5aa6

  Copy full SHA for 7da5aa6

• Standardize line endings at least within the repo.

  ekes

  committed
  227c6c3

  Copy full SHA for 227c6c3

Commits on Mar 11, 2022

• Fix to issue with query string not being URL-encoded closes inviqa#2

  Show description for cf3d1c7
  ekes

  committed
  cf3d1c7

  Copy full SHA for cf3d1c7

• discounts now applied to total amount calculation as per orphans#1

  Show description for d41332d
  ekes

  committed
  d41332d

  Copy full SHA for d41332d

• fixed return types in doc blocks

  Show description for cd70c74
  ekes

  committed
  cd70c74

  Copy full SHA for cd70c74

• Allow an override total in case of miscalculations closes orphans#1

  Show description for 89d97e5
  ekes

  committed
  89d97e5

  Copy full SHA for 89d97e5

• prevent invalid basket being sent

  Show description for d3c1196
  ekes

  committed
  d3c1196

  Copy full SHA for d3c1196

Commits on Mar 22, 2022

• Escape strings to prevent XML node errors.

  Show description for d98e44c
  ekes

  committed
  d98e44c

  Copy full SHA for d98e44c

• Escape all strings going into XML.

  ekes

  committed
  0fa838c

  Copy full SHA for 0fa838c

• Only allow A-Z a-z 0-9 - in SKUs.

  ekes

  committed
  421c1e8

  Copy full SHA for 421c1e8

• A late in the day fix to export the discounts in the XML basket.

  ekes

  committed
  8d404d5

  Copy full SHA for 8d404d5

• A late in the day fix to export the discounts in the XML basket.

  ekes

  committed
  9f7b44f

  Copy full SHA for 9f7b44f

• Add a check for correct price.

  Show description for 5edd630
  ekes

  committed
  5edd630

  Copy full SHA for 5edd630

• Send the order number if set, or id if not, within the VendorTxId.

  ekes

  committed
  322b414

  Copy full SHA for 322b414

• Handle failure return messaging.

  ekes

  committed
  1875ed4

  Copy full SHA for 1875ed4