-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update persister_oauth2.go to handle special character | coming in t… #3849
Open
Ajayn84
wants to merge
4
commits into
ory:master
Choose a base branch
from
Ajayn84:fix/escape_pipe_char_for_consent_flow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e scopes as part of consent request Url encoded and decoded while fetching values from the table, as "|" is a seperator used to store scopes
Ajayn84
changed the title
Update persister_oauth2.go to handle special character | coming in t…
Fix:Update persister_oauth2.go to handle special character | coming in t…
Sep 25, 2024
Ajayn84
changed the title
Fix:Update persister_oauth2.go to handle special character | coming in t…
fix:Update persister_oauth2.go to handle special character | coming in t…
Sep 25, 2024
Ajayn84
changed the title
fix:Update persister_oauth2.go to handle special character | coming in t…
fix: Update persister_oauth2.go to handle special character | coming in t…
Sep 25, 2024
Ajayn84
changed the title
fix: Update persister_oauth2.go to handle special character | coming in t…
fix: Update persister_oauth2.go to handle special character | coming in t… (https://github.com/ory/hydra/issues/3829)
Dec 2, 2024
Ajayn84
changed the title
fix: Update persister_oauth2.go to handle special character | coming in t… (https://github.com/ory/hydra/issues/3829)
fix: Update persister_oauth2.go to handle special character | coming in t…
Dec 2, 2024
Links to #3829 |
aeneasr
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a backwards incompatible change that will break all existing rows. I don't think there's appetite to fix this at the moment and the solution would need to be backwards compatible and well-tested. It's probably easier to just adjust the scope charset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he scopes as part of consent request
Url encoded and decoded while fetching values from the table, as "|" is a seperator used to store scopes
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments