Add option for additional kernel parameters #20971
Draft
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynechen55
force-pushed
the
wayne/poo#174757_add_linuxrc_reboot_timeout
branch
4 times, most recently
from
b1b29eb to
8265560
Compare
bsc#1231522 makes one point clear that we are looking into feature request to have some point before reboot to collect logs for further analysis and using something that already exists created exactly for this purpose which has the timeout value configurable on the linuxrc command line: - yast/yast-yast2#977 - yast/yast-installation#823 - openSUSE/installation-images#344 It's even briefly documented at https://en.opensuse.org/SDB:Linuxrc. In order to generalize this change and also make things much easier, using "extra kernel params" can help pass any desired parameters to kernel instead of just reboot_timeout.
waynechen55
force-pushed
the
wayne/poo#174757_add_linuxrc_reboot_timeout
branch
from
8265560 to
f918894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bsc#1231522 makes one point clear that we are looking into feature request to have some point before reboot to collect logs for further analysis and using something that already exists created exactly for this purpose which has the timeout value configurable on the linuxrc command line:
In order to generalize this change and also make things much easier, using "extra kernel params" can help pass any desired parameters to kernel instead of just reboot_timeout.
Add subroutine
get_guest_settingsto replicate desired settings to all guests involved.Pass extra kernel parameters in
guest_installation_runandhost_upgrade_generate_run_file.By the way,
tests/installation/ipxe_install.pmalready supportsEXTRABOOTPARAMS.This pull request should be merged together with https://github.com/SUSE/qa-automation/pull/856 and https://github.com/SUSE/qa-testsuites/pull/1112.
Verification Runs: