New Module for smartwatches display #18502 #21425
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upstream
…vices This performs some ui changes from the various layouts in the res/ folder in order for it to be usable on wear Os devices. There's a bunch of edits, and the project grows fast. Tested on 'wear os large' Android Studio
|
Many thanks for pushing smartwatch display forward. Though we can't merge this pull request as is. We need to investigate whether we need to create common library or incorporate changes in OsmAnd. We plan to do it in Q4 2024 - Q1 2025. |
|
Thank you for the update! Looking forward for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #18502, I decided to make the app usable for
wear osdevices.I've been stalling quite a bit, the project is quite big and I don't have a lot of exp in android dev but here it is.
A heads-up: There's a tons of changes add/edit. Mostly adds. See, I think it's possible to have a separate
resfiles when targetingwear osdevices, but I went the easiest way. A new module calledOsmAndWear.This is not a bait. I known there's
6,316 files changedbutIt's basically a clone of the
OsmAndfrom 54f673d, with the res folder edited.One can use some
difftool to check that.Of course, this doesn't fix all the layout. I am sure there are some ui stuff that aren't usable on the watches yet. I believe this pr is the right way to go, in order to make the dev more easier once it's in the pipeline. Having all the src files and stuff, to only focus on res.
Again, I am not sure that the new module is necessary, maybe it can be done without copying almost line by line the other
srcetc. from the mainOsmAnd.Also, an important thing: I had
disabled swipe to dismissin my previous test, to make it easier to navigate on the map. But using the same directives in thethemevalues>styles.xmlin the current state of the app doesn't work. I have "duplicated res error".That being said, can't wait to hear from you whether this is a welcome change or not.
Thanks