Use HTTPS instead of protocol relative URL #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://jeremywagner.me/blog/stop-using-the-protocol-relative-url/ for a detailed explanation of why you shoud not use protocol relative URL in 2018.
|
Is this going to be merged anytime soon? Using relative URLs was already a risk in 2018, but in 2024 it's a plain mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jeremywagner.me/blog/stop-using-the-protocol-relative-url/ for a detailed explanation of why you shoud not use protocol relative URL in 2018.
(I am not sure if this file is still used and where. I was just trying to understand the repo structure when I stumbled on this.)
Feel free to squash my commits if you want.