fix: make scorm panel cover entire height in fullscreen mode #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziafazal
reviewed
Feb 3, 2025
| @@ -57,9 +57,15 @@ function ScormXBlock(runtime, element, settings) { | |||
| if (settings.block_height > screen.height) { | |||
| $(e.target).css("height", screen.height); | |||
| } | |||
| // Override height and cover entire display in fullscreen | |||
There was a problem hiding this comment.
I think we should remove all this code and use requestFullscreen and exitFullscreen methods as described here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #96.
The scorm panel would retain any custom height set or the default 450px height in fullscreen mode thus defeating the purpose of the fullscreen mode.
We now cover the entire display in fullscreen mode.