feat: migrate to pyproject.toml and hatch #54
+89
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlabeeb03
commented
Jan 27, 2025
•
mlabeeb03
commented
- migrate from setup.py/setuptools to pyproject.toml/hatch.
- Completes tutor-credentials action item from [Epic] Migrate from setup.py/setuptools to pyproject.toml/hatch tutor#1190
| @@ -18,10 +18,8 @@ jobs: | |||
| uses: actions/setup-python@v5 | |||
| with: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: Upgrade pip | |||
| run: python -m pip install --upgrade pip setuptools | |||
There was a problem hiding this comment.
Don't we need pip upgrade in place? setuptools removal is understandable.
| [tool.hatch.build.targets.sdist] | ||
| # Disable strict naming, otherwise twine is not able to detect name/version | ||
| strict-naming = false | ||
| exclude = ["tests*"] |
There was a problem hiding this comment.
how different is the egg info generated by this?
There was a problem hiding this comment.
Hatch does not make an egg, it is replaced by dist-info.
I've compared their data and almost all the egg data is available in dist-info.
mlabeeb03
force-pushed
the
labeeb/tutor-credentials/pyproject.toml
branch
2 times, most recently
from
dd9cbc2 to
8332309
Compare
mlabeeb03
force-pushed
the
labeeb/tutor-credentials/pyproject.toml
branch
from
8332309 to
9be4128
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.