feat: allowing customization of notes repo and version #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
requested changes
Feb 21, 2023
README.rst
Outdated
| @@ -33,6 +33,8 @@ Configuration | |||
| - ``NOTES_HOST`` (default: ``"notes.{{ LMS_HOST }}"``) | |||
| - ``NOTES_MYSQL_DATABASE`` (default: ``"notes"``) | |||
| - ``NOTES_MYSQL_USERNAME`` (default: ``"notes"``) | |||
| - ``NOTES_CODE_REPO`` (default: ``"https://github.com/edx/edx-notes-api"``) | |||
There was a problem hiding this comment.
To be consistent with Tutor core, these new settings should be named NOTES_REPOSITORY and NOTES_VERSION.
There was a problem hiding this comment.
Good point. Can we use "NOTES_REPOSITORY_VERSION" instead please?
There was a problem hiding this comment.
@regisb addressed. I think this is ready to go
jfavellar90
force-pushed
the
Jhony/custom_code_and_version
branch
3 times, most recently
from
c94ecf9 to
76269f2
Compare
jfavellar90
force-pushed
the
Jhony/custom_code_and_version
branch
from
76269f2 to
069e262
Compare
jfavellar90
force-pushed
the
Jhony/custom_code_and_version
branch
from
069e262 to
600895c
Compare
regisb
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new configurations for the plugins:
NOTES_REPOSITORY: (default: "https://github.com/openedx/edx-notes-api")
NOTES_REPOSITORY_VERSION: (default: "{{ OPENEDX_COMMON_VERSION }}")
These will allow setting custom notes code repository and notes code version to build the image, which enables adding custom features for notes service on top of the default upstream version.