ArmoredChat v3 (DomainChat) (Rebase)

[Armored-Dragon]

Continued from #1261

• Settings seem to reset after each launch?

Fixes #1183
Closes #1252
Closes #1253
Fixes #1256
Fixes #1255
Closes #1258
Closes #1254

[ksuprynowicz]

Thank you! Everything looks fine except indentation in one of the files.

[ksuprynowicz]

Everything looks good :)

[Armored-Dragon]

Please wait on merging this until the line

overte/scripts/system/domainChat/domainChat.js

Line 270 in 3d16617

console.log("Sending notification to notificationCore:", `Display name: ${displayName}\n Message: ${message}`);

is removed. This was added for @ksuprynowicz to help with bug testing.

[ksuprynowicz]

In newest version there's no way of selecting the link sent in a message. Selecting it is currently necessary for opening in external browser.

[ksuprynowicz]

"External window" option in newest version does nothing for me, chat always run internally.
Links are also not wrapped, so they go outside window bounds.

[Armored-Dragon]

"External window" option in newest version does nothing for me, chat always run internally.

I can not replicate this on my machine. Currently this PR has debug logs to help figure out why settings are not being loaded on some clients. Please try and open the application and post what the settings are being set to.
It should look something like these two.

[02/18 13:59:46] [DEBUG] [overte.scriptengine] [domainChat.js] Loading settings:  {
[02/18 13:59:46] [DEBUG] [overte.scriptengine]     "enableEmbedding": false,
[02/18 13:59:46] [DEBUG] [overte.scriptengine]     "external_window": false,
[02/18 13:59:46] [DEBUG] [overte.scriptengine]     "join_notification": true,
[02/18 13:59:46] [DEBUG] [overte.scriptengine]     "maximum_messages": 40,
[02/18 13:59:46] [DEBUG] [overte.scriptengine]     "switchToInternalOnHeadsetUsed": true
[02/18 13:59:46] [DEBUG] [overte.scriptengine] }

[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml] Got settings:
[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml]  {
[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml]     "enableEmbedding": false,
[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml]     "external_window": false,
[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml]     "join_notification": true,
[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml]     "maximum_messages": 40,
[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml]     "switchToInternalOnHeadsetUsed": true
[02/18 13:59:46] [DEBUG] [qml] [domainChat.qml] }

[ksuprynowicz]

I also noticed issue with images being bigger that frame of a given message: