Experimentalt5tts finalizedtransformer #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paarth Neekhara <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
… gen directory (#41) Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
…d audio dir paths Signed-off-by: Shehzeen Hussain <[email protected]>
…roup, add shuffling Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
When the model generates an output that is very short (less than 2 ASR frames) the ASR and SSIM calculations will error out. We detect the error and invalidate the entire batch, setting WER/CER to 100% and SSIM to 0.0. The transcription is set to "<INVALID">. Note the metrics still written out to the `.metrics` files; they need to be ignored by any subsequent statistics calculations.
1. Skip groups that have any invalid records. 2. Allow the number of records to exactly match the number of audio files (vs requiring it to be strictly smaller). 3. Add `tqdm` to incidatea progress during long loops.
Signed-off-by: Shehzeen Hussain <[email protected]>
* bug fix in pareto ranking! Signed-off-by: Shehzeen Hussain <[email protected]> * ensure best record is never worse than worst record on any metric Signed-off-by: Shehzeen Hussain <[email protected]> --------- Signed-off-by: Shehzeen Hussain <[email protected]>
* bug fix in pareto ranking! Signed-off-by: Shehzeen Hussain <[email protected]> * ensure best record is never worse than worst record on any metric Signed-off-by: Shehzeen Hussain <[email protected]> * reward normalization using z-scores Signed-off-by: Shehzeen Hussain <[email protected]> * added comment in notebook for multilingual model Signed-off-by: Shehzeen Hussain <[email protected]> --------- Signed-off-by: Shehzeen Hussain <[email protected]>
…former' into experimentalt5tts_finalizedtransformer
Refining the handling of invalid entries in DPO preference selection.
* test_step(): handle invalid audio When the model generates an output that is very short (less than 2 ASR frames) the ASR and SSIM calculations will error out. We detect the error and invalidate the entire batch, setting WER/CER to 100% and SSIM to 0.0. The transcription is set to "<INVALID">. Note the metrics still written out to the `.metrics` files; they need to be ignored by any subsequent statistics calculations. * DPO: changes to preference pair creation 1. Skip groups that have any invalid records. 2. Allow the number of records to exactly match the number of audio files (vs requiring it to be strictly smaller). 3. Add `tqdm` to incidatea progress during long loops. * Comment * Fix merge issues and a bug Refining the handling of invalid entries in DPO preference selection. * Fix merge issues
…former' into experimentalt5tts_finalizedtransformer
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
|
beep boop 🤖: 🚨 The following files must be fixed before merge! Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information