[DEV-2122] implement in-memory caching for CMS API data retrieval #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new `cache.ts` file to manage an in-memory cache for API responses. - Updated multiple functions in `cmsApi.ts` to utilize the caching mechanism, improving performance by reducing redundant API calls. - Each API function now caches results for 15 minutes (900 seconds) using a unique cache key generated by `getCacheKey`. - Enhanced type safety by replacing `any` with `unknown` in the cache implementation. This change optimizes data fetching and reduces load on the CMS API.
🦋 Changeset detectedLatest commit: c2d44b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Bundle not found for branch |
MarcoPonchia
requested changes
Jan 27, 2025
Branch is not up to date with base branch@tommaso1 it seems this Pull Request is not updated with base branch. |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEV-2122 |
MarcoPonchia
requested changes
Jan 30, 2025
| const strapiHomepage = await fetchHomepage(buildEnv); | ||
| return makeHomepageProps(strapiHomepage); | ||
| }, | ||
| 900 // 15 minutes in seconds |
There was a problem hiding this comment.
maybe we should convert this into a env var ot at least a constant in this file
Suggested change
| 900 // 15 minutes in seconds | |
| 900 // 15 minutes in seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
cache.tsfile to manage an in-memory cache for API responses.cmsApi.tsto utilize the caching mechanism, improving performance by reducing redundant API calls.getCacheKey.anywithunknownin the cache implementation.This change optimizes data fetching and reduces load on the CMS API.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: