[CAI-303] fix personal page titles #1337
Conversation
MarBert
requested review from
MarcoPonchia,
marcobottaro and
tommaso1
as code owners
🦋 Changeset detectedLatest commit: 3748398 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue CAI-303 |
|
Bundle not found for branch |
| @@ -12,7 +12,7 @@ import { | |||
| useTheme, | |||
| } from '@mui/material'; | |||
| import Link from 'next/link'; | |||
| import React, { ReactNode, useState } from 'react'; | |||
| import React, { ReactNode, useEffect, useState } from 'react'; | |||
There was a problem hiding this comment.
Why are you adding this import?
| @@ -106,6 +106,7 @@ const Agreements = () => { | |||
|
|
|||
| return ( | |||
| <> | |||
| <title>DevPortal | Agreements</title> | |||
There was a problem hiding this comment.
I think you should add a new value to it.json file and use a translation to populate the title
There was a problem hiding this comment.
I think you should use generateMetadata function.
Here is an example in solutions/page.tsx
return makeMetadata({
title: 'Soluzioni',
url: `${baseUrl}/solutions`,
locale: 'it_IT',
});
}```
see https://nextjs.org/docs/app/api-reference/functions/generate-metadata
There was a problem hiding this comment.
Maybe you can use getTranslation
| @@ -54,63 +53,69 @@ const ChatbotHistory = () => { | |||
|
|
|||
| if (sessionId) { | |||
| return ( | |||
| <Box | |||
| <> | |||
| <title>DevPortal | Chatbot History</title> | |||
|
|
||
| return ( | ||
| <> | ||
| <title>DevPortal | Chatbot History</title> |
List of Changes
Some pages were missing the title
Motivation and Context
How Has This Been Tested?
on localhost
Screenshots (if appropriate):
Types of changes
Checklist: