Merge branch 'master' into IOPID-2634-io-login-zendesk-faq-banner

locales/de/index.yml

@@ -3207,7 +3207,8 @@ transaction:
       debtor: "Schuldner"
       iuv: "IUV"
       subject: "Zahlungsgrund"
-      noticeCode: "Kodex der Zahlungsmitteilung"
+      noticeCode: "Kodex der Zahlungsmitteilung/IUV"
+      noticeCodeAccessible: Codice avviso/Identificativo Univoco Versamento
       taxCode: "Steuernummer Körperschaft"
 FIMS:
   updateApp:

locales/en/index.yml

@@ -3554,8 +3554,13 @@ features:
         walletInactiveScreen:
           title: Attiva Documenti su IO per continuare
           subtitle: Per accedere con IT Wallet ai servizi online è necessario prima attivare la funzionalità Documenti su IO.
-          continue: Inizia
-          close: Non ora
+          primaryAction: Inizia
+          secondaryAction: Non ora
+        missingCredentialsScreen:
+          title: Mancano i dati contenuti in {{credentialName}}
+          subtitle: Aggiungi il documento al Portafoglio prima di continuare e poi riprova.
+          primaryAction: Aggiungi documento al Portafoglio
+          secondaryAction: Annulla
     trustmark:
       description: Mostra il QR Code per attestare l’autenticità del documento quando ti viene richiesto.
       qrCode: QR code autenticità credenziale
@@ -4216,7 +4221,8 @@ transaction:
       debtor: Debitore
       iuv: IUV
       subject: Oggetto del pagamento
-      noticeCode: Codice avviso
+      noticeCode: Codice avviso/IUV
+      noticeCodeAccessible: Codice avviso/Identificativo Univoco Versamento
       taxCode: Codice Fiscale Ente
 FIMS:
   updateApp:

locales/it/index.yml

@@ -3554,8 +3554,13 @@ features:
         walletInactiveScreen:
           title: Attiva Documenti su IO per continuare
           subtitle: Per accedere con IT Wallet ai servizi online è necessario prima attivare la funzionalità Documenti su IO.
-          continue: Inizia
-          close: Non ora
+          primaryAction: Inizia
+          secondaryAction: Non ora
+        missingCredentialsScreen:
+          title: Mancano i dati contenuti in {{credentialName}}
+          subtitle: Aggiungi il documento al Portafoglio prima di continuare e poi riprova.
+          primaryAction: Aggiungi documento al Portafoglio
+          secondaryAction: Annulla
     trustmark:
       description: Mostra il QR Code per attestare l’autenticità del documento quando ti viene richiesto.
       qrCode: QR code autenticità credenziale
@@ -4216,7 +4221,8 @@ transaction:
       debtor: Debitore
       iuv: IUV
       subject: Oggetto del pagamento
-      noticeCode: Codice avviso
+      noticeCode: Codice avviso/IUV
+      noticeCodeAccessible: Codice avviso/Identificativo Univoco Versamento
       taxCode: Codice Fiscale Ente
 FIMS:
   updateApp:

ts/components/screens/OperationResultScreenContent.tsx

@@ -31,11 +31,11 @@ type OperationResultScreenContentProps = WithTestID<{
   subtitleProps?: Pick<BodyProps, "textBreakStrategy" | "lineBreakStrategyIOS">;
   action?: Pick<
     ButtonSolidProps,
-    "label" | "accessibilityLabel" | "onPress" | "testID"
+    "label" | "accessibilityLabel" | "onPress" | "testID" | "icon"
   >;
   secondaryAction?: Pick<
     ButtonLinkProps,
-    "label" | "accessibilityLabel" | "onPress" | "testID"
+    "label" | "accessibilityLabel" | "onPress" | "testID" | "icon"
   >;
   isHeaderVisible?: boolean;
 }>;

ts/features/barcode/screens/BarcodeScanScreen.tsx

@@ -17,10 +17,7 @@ import {
   IOStackNavigationProp
 } from "../../../navigation/params/AppParamsList";
 import { useIOSelector } from "../../../store/hooks";
-import {
-  barcodesScannerConfigSelector,
-  isIdPayEnabledSelector
-} from "../../../store/reducers/backendStatus/remoteConfig";
+import { barcodesScannerConfigSelector } from "../../../store/reducers/backendStatus/remoteConfig";
 import { emptyContextualHelp } from "../../../utils/emptyContextualHelp";
 import { useIOBottomSheetAutoresizableModal } from "../../../utils/hooks/bottomSheet";
 import { IdPayPaymentRoutes } from "../../idpay/payment/navigation/routes";
@@ -46,11 +43,12 @@ import { usePagoPaPayment } from "../../payments/checkout/hooks/usePagoPaPayment
 import { FCI_ROUTES } from "../../fci/navigation/routes";
 import { paymentAnalyticsDataSelector } from "../../payments/history/store/selectors";
 import { ITW_REMOTE_ROUTES } from "../../itwallet/presentation/remote/navigation/routes.ts";
+import { isIdPayLocallyEnabledSelector } from "../../../store/reducers/persistedPreferences.ts";
 
 const BarcodeScanScreen = () => {
   const navigation = useNavigation<IOStackNavigationProp<AppParamsList>>();
   const openDeepLink = useOpenDeepLink();
-  const isIdPayEnabled = useIOSelector(isIdPayEnabledSelector);
+  const isIdPayEnabled = useIOSelector(isIdPayLocallyEnabledSelector);
   const paymentAnalyticsData = useIOSelector(paymentAnalyticsDataSelector);
 
   const { startPaymentFlowWithRptId } = usePagoPaPayment();

ts/features/itwallet/presentation/remote/machine/failure.ts

@@ -1,15 +1,31 @@
 import { RemoteEvents } from "./events.ts";
 
 export enum RemoteFailureType {
-  UNEXPECTED = "UNEXPECTED",
-  WALLET_INACTIVE = "WALLET_INACTIVE"
+  WALLET_INACTIVE = "WALLET_INACTIVE",
+  MISSING_CREDENTIALS = "MISSING_CREDENTIALS",
+  UNEXPECTED = "UNEXPECTED"
 }
 
-export type RemoteFailure = {
-  type: RemoteFailureType;
-  reason: unknown;
+/**
+ * Type that maps known reasons with the corresponding failure, in order to avoid unknowns as much as possible.
+ */
+export type ReasonTypeByFailure = {
+  [RemoteFailureType.WALLET_INACTIVE]: string;
+  [RemoteFailureType.MISSING_CREDENTIALS]: {
+    missingCredentials: Array<string>;
+  };
+  [RemoteFailureType.UNEXPECTED]: unknown;
 };
 
+type TypedRemoteFailures = {
+  [K in RemoteFailureType]: { type: K; reason: ReasonTypeByFailure[K] };
+};
+
+/*
+ * Union type of failures with the reason properly typed.
+ */
+export type RemoteFailure = TypedRemoteFailures[keyof TypedRemoteFailures];
+
 /**
  * Maps an event dispatched by the remote presentation machine to a failure object.
  * If the event contains an error, it is mapped to an unexpected failure.

ts/features/itwallet/presentation/remote/machine/guards.ts

@@ -7,5 +7,9 @@ export const createRemoteGuardsImplementation = (
 ) => ({
   isWalletActive: () =>
     itwLifecycleIsValidSelector(store.getState()) &&
-    isItwEnabledSelector(store.getState())
+    isItwEnabledSelector(store.getState()),
+
+  areRequiredCredentialsAvailable: () =>
+    // TODO: implementation depends on the remote presentation request
+    true
 });

ts/features/itwallet/presentation/remote/machine/machine.ts

@@ -22,7 +22,8 @@ export const itwRemoteMachine = setup({
   },
   actors: {},
   guards: {
-    isWalletActive: notImplemented
+    isWalletActive: notImplemented,
+    areRequiredCredentialsAvailable: notImplemented
   }
 }).createMachine({
   id: "itwRemoteMachine",

ts/features/itwallet/presentation/remote/screens/ItwRemoteFailureScreen.tsx

@@ -12,6 +12,9 @@ import { RemoteFailure, RemoteFailureType } from "../machine/failure.ts";
 import { useAvoidHardwareBackButton } from "../../../../../utils/useAvoidHardwareBackButton.ts";
 import { useDebugInfo } from "../../../../../hooks/useDebugInfo.ts";
 import I18n from "../../../../../i18n.ts";
+import { getCredentialNameFromType } from "../../../common/utils/itwCredentialUtils.ts";
+import { useIONavigation } from "../../../../../navigation/params/AppParamsList.ts";
+import { ITW_ROUTES } from "../../../navigation/routes.ts";
 
 export const ItwRemoteFailureScreen = () => {
   const failureOption =
@@ -30,6 +33,7 @@ type ContentViewProps = { failure: RemoteFailure };
 
 const ContentView = ({ failure }: ContentViewProps) => {
   const machineRef = ItwRemoteMachineContext.useActorRef();
+  const navigation = useIONavigation();
 
   useDebugInfo({
     failure: serializeFailureReason(failure)
@@ -59,18 +63,46 @@ const ContentView = ({ failure }: ContentViewProps) => {
             pictogram: "itWallet",
             action: {
               label: I18n.t(
-                "features.itWallet.presentation.remote.walletInactiveScreen.continue"
+                "features.itWallet.presentation.remote.walletInactiveScreen.primaryAction"
               ),
               onPress: () =>
                 machineRef.send({ type: "go-to-wallet-activation" })
             },
             secondaryAction: {
               label: I18n.t(
-                "features.itWallet.presentation.remote.walletInactiveScreen.close"
+                "features.itWallet.presentation.remote.walletInactiveScreen.secondaryAction"
               ),
               onPress: () => machineRef.send({ type: "go-to-wallet" })
             }
           };
+        case RemoteFailureType.MISSING_CREDENTIALS: {
+          const [missingCredential] = failure.reason.missingCredentials; // Only consider one credential for now
+          return {
+            title: I18n.t(
+              "features.itWallet.presentation.remote.missingCredentialsScreen.title",
+              { credentialName: getCredentialNameFromType(missingCredential) }
+            ),
+            subtitle: I18n.t(
+              "features.itWallet.presentation.remote.missingCredentialsScreen.subtitle"
+            ),
+            pictogram: "emptyWallet",
+            action: {
+              label: I18n.t(
+                "features.itWallet.presentation.remote.missingCredentialsScreen.primaryAction"
+              ),
+              onPress: () =>
+                navigation.navigate(ITW_ROUTES.MAIN, {
+                  screen: ITW_ROUTES.ONBOARDING
+                })
+            },
+            secondaryAction: {
+              label: I18n.t(
+                "features.itWallet.presentation.remote.missingCredentialsScreen.secondaryAction"
+              ),
+              onPress: () => machineRef.send({ type: "go-to-wallet" })
+            }
+          };
+        }
       }
     };
 

ts/features/payments/checkout/components/WalletPaymentFailureDetail.tsx

@@ -110,6 +110,7 @@ const WalletPaymentFailureDetail = ({ failure }: Props) => {
     accessibilityLabel: I18n.t(
       "wallet.payment.failure.PAYMENT_CANCELED.action"
     ),
+    icon: "categLearning",
     onPress: handleDiscoverMore
   };
 

ts/features/payments/receipts/screens/ReceiptCartItemDetailsScreen.tsx

@@ -84,7 +84,7 @@ const ReceiptCartItemDetailsScreen = () => {
               }
               label={I18n.t("transaction.details.operation.noticeCode")}
               accessibilityLabel={I18n.t(
-                "transaction.details.operation.noticeCode"
+                "transaction.details.operation.noticeCodeAccessible"
               )}
               value={cartItem.refNumberValue}
             />

ts/screens/profile/DeveloperModeSection.tsx

@@ -43,7 +43,7 @@ import {
 } from "../../store/reducers/authentication";
 import { isDebugModeEnabledSelector } from "../../store/reducers/debug";
 import {
-  isIdPayTestEnabledSelector,
+  isIdPayLocallyEnabledSelector,
   isIOMarkdownEnabledLocallySelector,
   isPagoPATestEnabledSelector,
   isPnTestEnabledSelector
@@ -349,7 +349,7 @@ const DesignSystemSection = () => {
 
 const PlaygroundsSection = () => {
   const navigation = useIONavigation();
-  const isIdPayTestEnabled = useIOSelector(isIdPayTestEnabledSelector);
+  const isIdPayTestEnabled = useIOSelector(isIdPayLocallyEnabledSelector);
 
   const playgroundsNavListItems: ReadonlyArray<PlaygroundsNavListItem> = [
     {
@@ -453,7 +453,7 @@ const DeveloperTestEnvironmentSection = ({
   const dispatch = useIODispatch();
   const isPagoPATestEnabled = useIOSelector(isPagoPATestEnabledSelector);
   const isPnTestEnabled = useIOSelector(isPnTestEnabledSelector);
-  const isIdPayTestEnabled = useIOSelector(isIdPayTestEnabledSelector);
+  const isIdPayTestEnabled = useIOSelector(isIdPayLocallyEnabledSelector);
 
   const onPagoPAEnvironmentToggle = (enabled: boolean) => {
     if (enabled) {

ts/screens/profile/SecurityScreen.tsx

@@ -18,8 +18,10 @@ import ROUTES from "../../navigation/routes";
 import { identificationRequest } from "../../store/actions/identification";
 import { preferenceFingerprintIsEnabledSaveSuccess } from "../../store/actions/persistedPreferences";
 import { useIODispatch, useIOSelector } from "../../store/hooks";
-import { isIdPayEnabledSelector } from "../../store/reducers/backendStatus/remoteConfig";
-import { isFingerprintEnabledSelector } from "../../store/reducers/persistedPreferences";
+import {
+  isFingerprintEnabledSelector,
+  isIdPayLocallyEnabledSelector
+} from "../../store/reducers/persistedPreferences";
 import { getFlowType } from "../../utils/analytics";
 import {
   biometricAuthenticationRequest,
@@ -51,7 +53,7 @@ const SecurityScreen = (): ReactElement => {
   const dispatch = useIODispatch();
   const isFingerprintEnabled = useIOSelector(isFingerprintEnabledSelector);
   const isIdPayCodeOnboarded = useIOSelector(isIdPayCodeOnboardedSelector);
-  const isIdPayEnabled = useIOSelector(isIdPayEnabledSelector);
+  const isIdPayEnabled = useIOSelector(isIdPayLocallyEnabledSelector);
   const isFimsHistoryEnabled = useIOSelector(fimsIsHistoryEnabledSelector);
   const navigation = useIONavigation();
   const [isBiometricDataAvailable, setIsBiometricDataAvailable] =

ts/store/reducers/backendStatus/remoteConfig.ts

@@ -19,7 +19,7 @@ import { getAppVersion, isVersionSupported } from "../../../utils/appVersion";
 import { backendStatusLoadSuccess } from "../../actions/backendStatus";
 import { Action } from "../../actions/types";
 import { isPropertyWithMinAppVersionEnabled } from "../featureFlagWithMinAppVersionStatus";
-import { isIdPayTestEnabledSelector } from "../persistedPreferences";
+import { isIdPayLocallyEnabledSelector } from "../persistedPreferences";
 import { GlobalState } from "../types";
 
 export type RemoteConfigState = O.Option<BackendStatus["config"]>;
@@ -279,7 +279,7 @@ export const isFciEnabledSelector = createSelector(
 
 export const isIdPayEnabledSelector = createSelector(
   remoteConfigSelector,
-  isIdPayTestEnabledSelector,
+  isIdPayLocallyEnabledSelector,
   (remoteConfig, isIdPayTestEnabled): boolean =>
     isIdPayTestEnabled ||
     pipe(

ts/store/reducers/persistedPreferences.ts

@@ -205,8 +205,8 @@ export const isMixpanelEnabled = (state: GlobalState): boolean | null =>
 export const isPnTestEnabledSelector = (state: GlobalState) =>
   state.persistedPreferences.isPnTestEnabled;
 
-export const isIdPayTestEnabledSelector = (state: GlobalState) =>
-  !!state.persistedPreferences?.isIdPayTestEnabled;
+export const isIdPayLocallyEnabledSelector = (state: GlobalState) =>
+  state.persistedPreferences?.isIdPayTestEnabled;
 
 // 'isDesignSystemEnabled' has been introduced without a migration
 // (PR https://github.com/pagopa/io-app/pull/4427) so there are cases