Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [IOBP-1115] Replace deprecated components and functions for IDPay #6586

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Jan 7, 2025

Short description

This PR is replacing legacy components for IDPay screens to align them with design standards

Warning

This PR depends on #6584

List of changes proposed in this pull request

  • Import FooterActions from design system
  • Replace RNavScreenWithLargeHeader with IOScrollViewWithLargeHeader
  • Replace GradientScrollView with IOScrollViewWithLargeHeader (thanks @dmnplb)
  • Replace jest deprecated functions (toBeCalledWith, toBeCalledTimes and toBeCalled)
  • Replace deprecated Layout of react-native-reanimated with LinearTransition
  • Remove back button in onboarding screens with IOScrollViewWithLargeHeader
  • Replace all scrollview with IOScrollViewWithLargeHeader

How to test

Ensure that all legacy components are replaced and properly aligned with standards

Preview

Old New
Screen.Recording.2025-01-08.at.17.49.58.mov
Screen.Recording.2025-01-08.at.17.13.07.mov
Screen.Recording.2025-01-08.at.17.44.15.mov
Screen.Recording.2025-01-08.at.17.13.44.mov
Screen.Recording.2025-01-08.at.17.53.58.mov
Screen.Recording.2025-01-08.at.17.28.48.mov
Screen.Recording.2025-01-08.at.17.52.13.mov
Screen.Recording.2025-01-08.at.17.29.27.mov

replace TopScreenComponent with useHeaderSecondLevel
replace BaseScreenComponent with useHeaderSecondLevel
Replace RNavScreenWithLargeHeader with IOScrollViewWithLargeHeader
replace Layout with LinearTransition
replace GradientScrollView with IOScrollView
@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Jan 7, 2025
@LeleDallas LeleDallas self-assigned this Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-1115

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 2.27273% with 43 lines in your changes missing coverage. Please review.

Project coverage is 49.39%. Comparing base (40f6224) to head (19338e7).

Files with missing lines Patch % Lines
...pay/configuration/screens/IbanEnrollmentScreen.tsx 0.00% 9 Missing ⚠️
...nfiguration/screens/ConfigurationSuccessScreen.tsx 0.00% 8 Missing ⚠️
...pay/configuration/screens/IbanOnboardingScreen.tsx 0.00% 7 Missing ⚠️
...figuration/screens/InstrumentsEnrollmentScreen.tsx 0.00% 6 Missing ⚠️
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 0.00% 4 Missing ⚠️
...nboarding/screens/BoolValuePrerequisitesScreen.tsx 0.00% 3 Missing ⚠️
...boarding/screens/MultiValuePrerequisitesScreen.tsx 0.00% 3 Missing ⚠️
...atures/idpay/code/screens/IdPayCodeRenewScreen.tsx 0.00% 1 Missing ⚠️
...uration/screens/IbanConfigurationLandingScreen.tsx 0.00% 1 Missing ⚠️
...uration/screens/IdPayDiscountInstrumentsScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6586      +/-   ##
==========================================
+ Coverage   49.34%   49.39%   +0.05%     
==========================================
  Files        1566     1565       -1     
  Lines       32287    32243      -44     
  Branches     7288     7324      +36     
==========================================
- Hits        15932    15927       -5     
+ Misses      16316    16267      -49     
- Partials       39       49      +10     
Files with missing lines Coverage Δ
ts/features/idpay/barcode/navigation/navigator.tsx 66.66% <ø> (ø)
...idpay/barcode/screens/IdPayBarcodeResultScreen.tsx 15.15% <ø> (ø)
ts/features/idpay/code/navigation/navigator.tsx 66.66% <ø> (ø)
...ures/idpay/code/screens/IdPayCodeDisplayScreen.tsx 96.00% <ø> (-0.16%) ⬇️
...tures/idpay/configuration/navigation/navigator.tsx 37.50% <ø> (ø)
...ion/screens/InitiativeConfigurationIntroScreen.tsx 15.78% <ø> (+0.78%) ⬆️
...y/details/screens/IdPayInitiativeDetailsScreen.tsx 83.52% <100.00%> (+0.19%) ⬆️
...dpay/details/screens/IdPayOperationsListScreen.tsx 8.82% <ø> (ø)
...features/idpay/onboarding/navigation/navigator.tsx 37.50% <ø> (ø)
...ures/idpay/onboarding/screens/CompletionScreen.tsx 11.11% <ø> (-8.89%) ⬇️
... and 11 more

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40f6224...19338e7. Read the comment docs.

Replace IOScrollView with IOScrollViewWithLargeHeader as it provides more props for rendering purpose
Copy link

dpulls bot commented Jan 15, 2025

🎉 All dependencies have been resolved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant