Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOPID-2579] add management of remote portal urls #6594

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

chore: [IOPID-2579] add management of remote portal urls #6594

wants to merge 21 commits into from

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Jan 9, 2025 •
edited
Loading

Warning

This PR depends on pagopa/io-services-metadata#916 pagopa/io-dev-api-server#454 #6579 #6577

Note

Need to edit IO_SERVICES_METADATA_VERSION ref on scripts/generate-api-models.sh after merge on io-services-metadata

Short description

Add logic to manage the remote urls

List of changes proposed in this pull request

  • Add new ref to metadata
  • Add selector to get the value of remote urls from the cdn absolutePortalLinksSelector
  • Add selector to manage the link building (base path from the cdn + body url) replaceBaseUrlSelector
  • Edit hardcoded references to https://io.italia.it/ and https://ioapp.it/ using selectors
  • Delete unused hardcoded references to https://io.italia.it/ and https://ioapp.it/ into the code

Demo

remote_links_1080_new.mov

How to test

Run the application and check that all links are working properly (as-is operation)

@Ladirico Ladirico added the IO-A&I IO - Autenticazione e Identità label Jan 9, 2025
@Ladirico Ladirico self-assigned this Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2579

@Ladirico Ladirico marked this pull request as ready for review January 10, 2025 09:43
@Ladirico Ladirico changed the title [IOPID-2579] add management of remote portal urls chore: [IOPID-2579] add management of remote portal urls Jan 10, 2025
@Ladirico Ladirico requested a review from ChrisMattew January 10, 2025 14:30
ChrisMattew
ChrisMattew approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@ChrisMattew ChrisMattew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local env and everything works as expected! LGTM! 💪🏻

shadowsheep1
shadowsheep1 requested changes Jan 13, 2025
View reviewed changes
ts/config.ts Show resolved Hide resolved
ts/features/bonus/cgn/__mock__/availableMerchantDetail.ts Show resolved Hide resolved
ts/features/itwallet/walletInstance/hook/useItwWalletInstanceRevocationAlert.ts Show resolved Hide resolved
ts/store/reducers/__mock__/backendStatus.ts Outdated Show resolved Hide resolved
ts/store/reducers/__mock__/backendStatus.ts Outdated Show resolved Hide resolved
ts/store/reducers/backendStatus/remoteConfig.ts Outdated Show resolved Hide resolved
ts/store/reducers/backendStatus/remoteConfig.ts Outdated Show resolved Hide resolved
@dpulls dpulls
Copy link

dpulls bot commented Jan 15, 2025

🎉 All dependencies have been resolved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMattew ChrisMattew ChrisMattew approved these changes

@shadowsheep1 shadowsheep1 shadowsheep1 approved these changes

@thisisjp thisisjp Awaiting requested review from thisisjp thisisjp is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

Assignees

@Ladirico Ladirico

Labels
dont-merge ✋ IO-A&I IO - Autenticazione e Identità
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ladirico @shadowsheep1 @ChrisMattew