-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOCOM-1848] Analytics for Push Notifications Engagement #6598
Conversation
Tests for isForceDismissAndNotUnreadMessagesHiddenSelector, pushNotificationsBannerForceDismissionDateSelector, unreadMessagesCountAfterForceDismissionSelector selectors
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOCOM-1848 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6598 +/- ##
==========================================
+ Coverage 46.00% 49.54% +3.53%
==========================================
Files 1427 1566 +139
Lines 29927 32395 +2468
Branches 6734 7297 +563
==========================================
+ Hits 13769 16049 +2280
- Misses 16128 16307 +179
- Partials 30 39 +9
... and 290 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR adds the analytics for the disabled push notification permissions engagement banners.
List of changes proposed in this pull request
BANNER
: for Itw, PushNotification and ProfileSettings bannersTAP_BANNER
: for Itw, PushNotification and ProfileSettings bannersCLOSE_BANNER
: for Itw, PushNotification and ProfileSettings bannersPUSH_NOTIF_SYSTEM_ALERT
: for system permissions popupPUSH_NOTIF_THIRD_DISMISS_ALERT
: for bottom sheet opening on third dismissal of the push notifications bannerPUSH_NOTIF_THIRD_DISMISS_ALERT_INTERACTION
: for bottom sheet (above) interaction CTAPUSH_NOTIF_BANNER_FORCE_SHOW
: when the dismissed push notification banner has to be shown againPUSH_NOTIF_BANNER_STILL_HIDDEN
: when the dismissed push notification banner is not to be shown againHow to test
For every event, check that it is tracked with the proper properties