Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-1848] Analytics for Push Notifications Engagement #6598

Merged
merged 19 commits into from
Jan 16, 2025

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR adds the analytics for the disabled push notification permissions engagement banners.

List of changes proposed in this pull request

  • BANNER: for Itw, PushNotification and ProfileSettings banners
  • TAP_BANNER: for Itw, PushNotification and ProfileSettings banners
  • CLOSE_BANNER: for Itw, PushNotification and ProfileSettings banners
  • PUSH_NOTIF_SYSTEM_ALERT: for system permissions popup
  • PUSH_NOTIF_THIRD_DISMISS_ALERT: for bottom sheet opening on third dismissal of the push notifications banner
  • PUSH_NOTIF_THIRD_DISMISS_ALERT_INTERACTION: for bottom sheet (above) interaction CTA
  • PUSH_NOTIF_BANNER_FORCE_SHOW: when the dismissed push notification banner has to be shown again
  • PUSH_NOTIF_BANNER_STILL_HIDDEN: when the dismissed push notification banner is not to be shown again

How to test

For every event, check that it is tracked with the proper properties

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1848

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.54%. Comparing base (c3b2f95) to head (4478970).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6598      +/-   ##
==========================================
+ Coverage   46.00%   49.54%   +3.53%     
==========================================
  Files        1427     1566     +139     
  Lines       29927    32395    +2468     
  Branches     6734     7297     +563     
==========================================
+ Hits        13769    16049    +2280     
- Misses      16128    16307     +179     
- Partials       30       39       +9     
Files with missing lines Coverage Δ
...ltiBanner/components/LandingScreenBannerPicker.tsx 100.00% <100.00%> (ø)
ts/features/pushNotifications/analytics/index.ts 100.00% <100.00%> (ø)
...tifications/components/PushNotificationsBanner.tsx 100.00% <100.00%> (+86.36%) ⬆️
...tions/hooks/usePushNotificationsBannerTracking.tsx 100.00% <100.00%> (ø)
.../sagas/profileAndSystemNotificationsPermissions.ts 100.00% <100.00%> (ø)
...ns/store/selectors/notificationsBannerDismissed.ts 100.00% <100.00%> (ø)
ts/screens/profile/ProfileMainScreenTopBanner.tsx 100.00% <100.00%> (ø)
ts/screens/profile/analytics/index.ts 53.12% <100.00%> (+14.66%) ⬆️
...ens/profile/components/SettingsDiscoveryBanner.tsx 100.00% <100.00%> (+25.00%) ⬆️

... and 290 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b2f95...4478970. Read the comment docs.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth added this pull request to the merge queue Jan 16, 2025
Merged via the queue into master with commit 0ba5a4d Jan 16, 2025
21 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1848-lpAnalytics branch January 16, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants