[SIW-1953] Mixpanel tracking of new ITWallet feature #6601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-new-itw-mixpanel-events
RiccardoMolinari95
requested review from
ChrisMattew,
gispada and
freddi301
as code owners
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
Vangaorth
requested changes
Jan 15, 2025
ts/features/itwallet/presentation/components/ItwPresentationDetailsFooter.tsx
Outdated
Show resolved
Hide resolved
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
RiccardoMolinari95
temporarily deployed
to
dev
GitHub Actions
Inactive
…lector in ItwPresentationDetailsFooter for iPatente CTA
mastro993
reviewed
Jan 15, 2025
| */ | ||
| export const itwIsIPatenteCtaEnabledSelector = createSelector( | ||
| export const itwIPatenteCtaSelector = createSelector( |
There was a problem hiding this comment.
Suggested change
| export const itwIPatenteCtaSelector = createSelector( | |
| export const itwIPatenteCtaConfigSelector = createSelector( |
mastro993
reviewed
Jan 15, 2025
| @@ -131,28 +133,40 @@ const getCredentialActions = (credentialType: string): React.ReactNode => | |||
| * Renders the IPatente service action item | |||
| */ | |||
| const IPatenteListItemAction = () => { | |||
| const isIPatenteEnabled = useIOSelector(itwIsIPatenteCtaEnabledSelector); | |||
| const iPatenteCtaSelector = useIOSelector(itwIPatenteCtaSelector); | |||
There was a problem hiding this comment.
Suggested change
| const iPatenteCtaSelector = useIOSelector(itwIPatenteCtaSelector); | |
| const ctaConfig = useIOSelector(itwIPatenteCtaConfigSelector); |
…-new-itw-mixpanel-events
Vangaorth
previously approved these changes
Jan 15, 2025
mastro993
reviewed
Jan 15, 2025
Comment on lines
153
to
154
| //TODO Change with a new source | ||
| "message_detail" |
There was a problem hiding this comment.
I think we should solve this ambiguity in this PR
There was a problem hiding this comment.
Yes I know, in fact I inserted the tag don't merge. I'm still waiting for an answer on what source to insert; when I know what to put I will delete the TODO and change the source to the correct one
Base automatically changed from
SIW-1918-add-ipatente-cta-in-mdl-details-screen
to
master
January 15, 2025 15:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR add the tracking on mixpanel of some ITWallet events
Warning
Depens on #6577
List of changes proposed in this pull request
trackItwStatusWalletAttestationFailurewhen the wallet attestation fails.trackItwStatusCredentialAttestationFailurewhen the credential attestation failstrackItwTrustmarkRenewFailurewhen the generation of the QR Code for attesting the authenticity of the credential failstrackCredentialCardModalwhen a credential is viewed in landscape modeFIMS_STARTby clicking the CTA towardsiPatentethrough thetrackAuthenticationStartfunctionitwIPatenteCtaConfigSelectorto retrieve the iPatente cta remote configHow to test
Verify that the newly added events are tracked correctly