-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [IOAPPX-462] Fix flickering behaviour in the search screens (Messages, Services) on iOS #6603
Open
dmnplb
wants to merge
6
commits into
IOPLT-810-set-allow-font-scaling-to-true-by-default
Choose a base branch
from
IOAPPX-462-fix-flickering-issue-search-ios
base: IOPLT-810-set-allow-font-scaling-to-true-by-default
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Short description This pull request focuses on refactoring multiple screens in the `IDPay` feature to use the `useHeaderSecondLevel` hook instead of the `TopScreenComponent` and `BaseScreenComponent` components. Additionally, it includes a minor update to a test file ## List of changes proposed in this pull request - Replaced `TopScreenComponent` with `useHeaderSecondLevel` hook - Replaced `BaseScreenComponent` with `useHeaderSecondLevel` hook ## How to test Ensure that all IDPay headers are fully aligned with the established design requirements --------- Co-authored-by: Alessandro <[email protected]>
## Short description This PR focus on enhancing the tracking of payment methods, receipt details, and user interactions adding missing events/properties to `Mixpanel`. ## List of changes proposed in this pull request - Added `trackPaymentWalletMethodDetail` function to track details of payment methods - Updated `handleOnMethodPress` function to include tracking of payment method selection and status - Added `organization_fiscal_code` and `payment_status` to the `trackPaymentsOpenReceipt` function - `trackPaymentsSaveAndShareReceipt` to include additional receipt details - Added `trackReceiptFilterUsage` function to track the usage of receipt category filters - Added tracking for receipt filter usage in `ReceiptListScreen` - Updated `ReceiptDetailsScreen` and `ReceiptPreviewScreen` to include more comprehensive analytics tracking when downloading and sharing receipts ## How to test Verify with `Proxyman` that all data is being transmitted as specified in the open task description --------- Co-authored-by: Alessandro <[email protected]>
…W screens (#6595) ## Short description This PR prevents screenshots and screen recordings in several IT Wallet screens. In order to work on iOS, `react-native-flag-secure-android` (currently used) has been changed with `react-native-screenshot-prevent`. The implementation is the following: - On Android it leverages the `FLAG_SECURE` option; - On iOS it creates a hidden secure text field, that renders the screen blank. ## List of changes proposed in this pull request - Removed `react-native-flag-secure-android` - Installed `react-native-screenshot-prevent` - Added ITW routes to `screenBlackList` ## How to test Ensure it is not possible to take screenshots or record the content of the screen in the following: - CIE pin screen during identification - Trust issuer screen - Credential preview and detail (including trustmark) Be sure to **disable debug mode**, because `isAllowedSnapshotCurrentScreen` always returns true in debug. > [!NOTE] > iOS does not seem to offer a direct API to disable screenshots. `react-native-screenshot-prevent` makes use of a workaround solution, so please test it thoroughly on iOS.
dmnplb
added
Bug 🐞
Design System
New visual language and reduction of previous UI clutter
labels
Jan 15, 2025
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
January 15, 2025 11:15
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOAPPX-462 |
dmnplb
changed the base branch from
master
to
IOPLT-810-set-allow-font-scaling-to-true-by-default
January 15, 2025 11:32
…to IOAPPX-462-fix-flickering-issue-search-ios
dmnplb
changed the title
[IOAPPX-462] Fix flickering behaviour in the search screens (Messages, Services) on iOS
fix: [IOAPPX-462] Fix flickering behaviour in the search screens (Messages, Services) on iOS
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This PR depends on:
allowFontScaling
by default for all citizens #6561Short description
This PR fixes the flickering behaviour in the
SearchInput
on iOS, when bolder text is enabled.List of changes proposed in this pull request
io-app-design-system
to4.4.6
Preview
The visual issue before the fix:
breathing-intensifies.mp4
Related PR
SearchInput
on iOS io-app-design-system#379How to test