Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOAPPX-462] Fix flickering behaviour in the search screens (Messages, Services) on iOS #6603

Open
wants to merge 6 commits into
base: IOPLT-810-set-allow-font-scaling-to-true-by-default
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 15, 2025

Short description

This PR fixes the flickering behaviour in the SearchInput on iOS, when bolder text is enabled.

List of changes proposed in this pull request

  • Update io-app-design-system to 4.4.6

Preview

The visual issue before the fix:

breathing-intensifies.mp4

Related PR

How to test

  1. Launch the app
  2. Enable bolder text on iOS
  3. Search for something in messages or services

github-actions bot and others added 5 commits January 14, 2025 22:16
## Short description
This pull request focuses on refactoring multiple screens in the `IDPay`
feature to use the `useHeaderSecondLevel` hook instead of the
`TopScreenComponent` and `BaseScreenComponent` components. Additionally,
it includes a minor update to a test file

## List of changes proposed in this pull request
- Replaced `TopScreenComponent` with `useHeaderSecondLevel` hook
- Replaced `BaseScreenComponent` with `useHeaderSecondLevel` hook

## How to test
Ensure that all IDPay headers are fully aligned with the established
design requirements

---------

Co-authored-by: Alessandro <[email protected]>
## Short description
This PR focus on enhancing the tracking of payment methods, receipt
details, and user interactions adding missing events/properties to
`Mixpanel`.

## List of changes proposed in this pull request
- Added `trackPaymentWalletMethodDetail` function to track details of
payment methods
- Updated `handleOnMethodPress` function to include tracking of payment
method selection and status
- Added `organization_fiscal_code` and `payment_status` to the
`trackPaymentsOpenReceipt` function
- `trackPaymentsSaveAndShareReceipt` to include additional receipt
details
- Added `trackReceiptFilterUsage` function to track the usage of receipt
category filters
- Added tracking for receipt filter usage in `ReceiptListScreen` 
- Updated `ReceiptDetailsScreen` and `ReceiptPreviewScreen` to include
more comprehensive analytics tracking when downloading and sharing
receipts

## How to test
Verify with `Proxyman` that all data is being transmitted as specified
in the open task description

---------

Co-authored-by: Alessandro <[email protected]>
…W screens (#6595)

## Short description
This PR prevents screenshots and screen recordings in several IT Wallet
screens. In order to work on iOS, `react-native-flag-secure-android`
(currently used) has been changed with
`react-native-screenshot-prevent`.

The implementation is the following:
- On Android it leverages the `FLAG_SECURE` option;
- On iOS it creates a hidden secure text field, that renders the screen
blank.

## List of changes proposed in this pull request
- Removed `react-native-flag-secure-android`
- Installed `react-native-screenshot-prevent` 
- Added ITW routes to `screenBlackList`

## How to test
Ensure it is not possible to take screenshots or record the content of
the screen in the following:
- CIE pin screen during identification
- Trust issuer screen 
- Credential preview and detail (including trustmark)

Be sure to **disable debug mode**, because
`isAllowedSnapshotCurrentScreen` always returns true in debug.

> [!NOTE]
> iOS does not seem to offer a direct API to disable screenshots.
`react-native-screenshot-prevent` makes use of a workaround solution, so
please test it thoroughly on iOS.
@dmnplb dmnplb added Bug 🐞 Design System New visual language and reduction of previous UI clutter labels Jan 15, 2025
@dmnplb dmnplb requested review from ChrisMattew, gispada, freddi301 and a team as code owners January 15, 2025 11:15
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOAPPX-462

@dmnplb dmnplb changed the base branch from master to IOPLT-810-set-allow-font-scaling-to-true-by-default January 15, 2025 11:32
…to IOAPPX-462-fix-flickering-issue-search-ios
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 32.05128% with 53 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (e3328a0) to head (bfdb4ca).

Files with missing lines Patch % Lines
.../profile/playgrounds/IdPayOnboardingPlayground.tsx 0.00% 6 Missing ⚠️
...uration/screens/IdPayDiscountInstrumentsScreen.tsx 0.00% 5 Missing ⚠️
...figuration/screens/InstrumentsEnrollmentScreen.tsx 0.00% 5 Missing ⚠️
...pay/configuration/screens/IbanEnrollmentScreen.tsx 0.00% 4 Missing ⚠️
...boarding/screens/MultiValuePrerequisitesScreen.tsx 0.00% 4 Missing ⚠️
ts/features/payments/receipts/analytics/index.ts 40.00% 3 Missing ⚠️
...atures/idpay/code/screens/IdPayCodeRenewScreen.tsx 0.00% 2 Missing ⚠️
ts/features/payments/home/analytics/index.ts 33.33% 2 Missing ⚠️
...ts/home/components/PaymentsHomeUserMethodsList.tsx 50.00% 2 Missing ⚠️
...payments/receipts/screens/ReceiptPreviewScreen.tsx 0.00% 2 Missing ⚠️
... and 17 more
Additional details and impacted files

Impacted file tree graph

@@                                   Coverage Diff                                   @@
##           IOPLT-810-set-allow-font-scaling-to-true-by-default    #6603      +/-   ##
=======================================================================================
- Coverage                                                49.36%   49.33%   -0.03%     
=======================================================================================
  Files                                                     1565     1565              
  Lines                                                    32231    32276      +45     
  Branches                                                  7336     7338       +2     
=======================================================================================
+ Hits                                                     15910    15923      +13     
- Misses                                                   16271    16315      +44     
+ Partials                                                    50       38      -12     
Files with missing lines Coverage Δ
...ures/idpay/code/screens/IdPayCodeDisplayScreen.tsx 96.15% <100.00%> (+0.15%) ⬆️
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 36.11% <100.00%> (+1.82%) ⬆️
.../features/payments/history/store/reducers/index.ts 51.11% <ø> (ø)
...payments/receipts/components/HideReceiptButton.tsx 5.88% <ø> (ø)
...payments/receipts/screens/ReceiptDetailsScreen.tsx 7.69% <ø> (ø)
ts/utils/hooks/usePreventScreenCapture.ts 100.00% <100.00%> (ø)
...uration/screens/IbanConfigurationLandingScreen.tsx 20.00% <0.00%> (-2.23%) ⬇️
...pay/configuration/screens/IbanOnboardingScreen.tsx 6.66% <0.00%> (ø)
...ion/screens/InitiativeConfigurationIntroScreen.tsx 15.00% <0.00%> (+0.71%) ⬆️
...ures/idpay/onboarding/screens/CompletionScreen.tsx 20.00% <0.00%> (-2.23%) ⬇️
... and 23 more

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3328a0...bfdb4ca. Read the comment docs.

@dmnplb dmnplb changed the title [IOAPPX-462] Fix flickering behaviour in the search screens (Messages, Services) on iOS fix: [IOAPPX-462] Fix flickering behaviour in the search screens (Messages, Services) on iOS Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants