Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Cross): [IOAPPX-466] replace peter-evans action with gh #6627

Merged
merged 20 commits into from
Jan 27, 2025

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Jan 22, 2025

Short description

This PR replaces community action to manipulate PR comments by leveraging the use of gh in PR title check workflows.
It uses a safe way to handle the title inside a bash script, avoiding injections from the PR Title.

How to test

Try to change the PR title to see the workflows in action in different scenarios.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@shadowsheep1 shadowsheep1 changed the title chore: [IOAPPX-466] replace peter-evans with gh chore(Cross): [IOAPPX-466] replace peter-evans with gh Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.54%. Comparing base (7132e67) to head (23b0c20).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6627   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files        1547     1547           
  Lines       32174    32174           
  Branches     7236     7237    +1     
=======================================
  Hits        15941    15941           
  Misses      16195    16195           
  Partials       38       38           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7132e67...23b0c20. Read the comment docs.

@shadowsheep1 shadowsheep1 marked this pull request as ready for review January 22, 2025 13:13
@shadowsheep1 shadowsheep1 changed the title chore(Cross): [IOAPPX-466] replace peter-evans with gh chore(Cross): [IOAPPX-466] replace peter-evans with gh Jan 22, 2025
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants