Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(privacy): [IOPID-2609] Disable screenshots and recordings in PinCreation and CiePinScreen components #6628

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Jan 22, 2025

Short description

This PR adds protection to the screens for creating/editing the device PIN and entering the CIE PIN to prevent these screens from being captured by screenshots or recordings.

List of changes proposed in this pull request

  • Upgraded DS lib
  • Added the usePreventScreenCapture hook to the PinCreation component
  • Added the usePreventScreenCapture hook to the CiePinScreen component

Demo

iOS
Cie pin insertion Device Pin creation/editing
iOS-prevent-recording-cie-pin-screen.MP4
iOS-prevent-recording-pin-creation.MP4
Android
Cie pin insertion Device Pin creation/editing
android-prevent-recording-cie-pin-screen.mp4
android-prevent-recording-pin-creation.mp4

How to test

Perform screen recording during login with CIE + PIN and during the creation/editing of the device PIN. The respective screens should appear obscured in the recording.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR Title Validation for conventional commit type

✅ All good! PR title follows conventional commit type.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2609

@ChrisMattew ChrisMattew self-assigned this Jan 22, 2025
@ChrisMattew ChrisMattew added the IO-A&I IO - Autenticazione e Identità label Jan 22, 2025
@ChrisMattew ChrisMattew changed the title [IOPID-2609] Disable screenshots and recordings on PinCreation and CiePinScreen components [IOPID-2609] Disable screenshots and recordings in PinCreation and CiePinScreen components Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.88%. Comparing base (3409b7a) to head (818c8c1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ts/screens/authentication/cie/CiePinScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6628   +/-   ##
=======================================
  Coverage   49.88%   49.88%           
=======================================
  Files        1566     1566           
  Lines       32385    32387    +2     
  Branches     7337     7337           
=======================================
+ Hits        16156    16157    +1     
- Misses      16180    16181    +1     
  Partials       49       49           
Files with missing lines Coverage Δ
ts/components/screens/PinCreation/PinCreation.tsx 79.74% <100.00%> (+0.25%) ⬆️
ts/screens/authentication/cie/CiePinScreen.tsx 6.77% <0.00%> (-0.12%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3409b7a...818c8c1. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a note: you could also add a screen to demonstrate the correct functioning in that case too. Anyway, it all fits, I tested it and it works!
Good Job! 🚀

@ChrisMattew ChrisMattew enabled auto-merge January 22, 2025 16:31
@ChrisMattew ChrisMattew added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit 8395b5d Jan 22, 2025
22 checks passed
@ChrisMattew ChrisMattew deleted the IOPID-2609-avoid-screenshots-in-certain-screens branch January 22, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quando si registra lo schermo è possibile vedere i tasti premuti per l'inserimento di codici segreti
3 participants