-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(privacy): [IOPID-2609] Disable screenshots and recordings in PinCreation and CiePinScreen components #6628
feat(privacy): [IOPID-2609] Disable screenshots and recordings in PinCreation and CiePinScreen components #6628
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-2609 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6628 +/- ##
=======================================
Coverage 49.88% 49.88%
=======================================
Files 1566 1566
Lines 32385 32387 +2
Branches 7337 7337
=======================================
+ Hits 16156 16157 +1
- Misses 16180 16181 +1
Partials 49 49
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just a note: you could also add a screen to demonstrate the correct functioning in that case too. Anyway, it all fits, I tested it and it works!
Good Job! 🚀
Short description
This PR adds protection to the screens for creating/editing the device PIN and entering the CIE PIN to prevent these screens from being captured by screenshots or recordings.
List of changes proposed in this pull request
DS
libusePreventScreenCapture
hook to thePinCreation
componentusePreventScreenCapture
hook to theCiePinScreen
componentDemo
iOS
iOS-prevent-recording-cie-pin-screen.MP4
iOS-prevent-recording-pin-creation.MP4
Android
android-prevent-recording-cie-pin-screen.mp4
android-prevent-recording-pin-creation.mp4
How to test
Perform screen recording during login with CIE + PIN and during the creation/editing of the device PIN. The respective screens should appear obscured in the recording.