refactor: [IOBP-1152] Replace legacy BaseScreenComponent
#6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace BaseScreenComponent with IOScrollViewWithLargeHeader
replace BaseScreenComponent with IOScrollViewWithLargeHeader
this will be visible only on iOS, for Android is integrated with IOScrollViewWithLargeHeader
LeleDallas
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6636 +/- ##
==========================================
- Coverage 49.54% 49.53% -0.02%
==========================================
Files 1547 1547
Lines 32179 32187 +8
Branches 7286 7248 -38
==========================================
Hits 15944 15944
- Misses 16197 16205 +8
Partials 38 38
Continue to review full report in Codecov by Sentry.
|
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request primarily focuses on improving the user interface and navigation for the payments feature by replacing existing components with the
IOScrollViewWithLargeHeadercomponent and making adjustments to screen options.These changes also address a dark mode issue related to the B&P stream
List of changes proposed in this pull request
BaseScreenComponentandScrollViewwithIOScrollViewWithLargeHeaderInputAccessoryViewfor showing CTA on iOS (thanks @dmnplb)How to test
Ensure that the app works as before with no regression
Tip: Test it on a real device 📱 to ensure proper functionality across all scenarios
Preview
Screen.Recording.2025-01-24.at.15.36.16.mov
ScreenRecording_01-24-2025.15-31-51_1.MP4