Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1989] Add dismiss confirmation dialog to IT Wallet identification flows #6641

Merged
merged 9 commits into from
Feb 3, 2025

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 27, 2025

Short description

This PR adds the dismiss confirmation dialog in some identification flow screens.

List of changes proposed in this pull request

  • Added useHardwareBackButton inside the useItwDismissalDialog to show the dialog also for hardware back buttons
  • Added useItwDismissalDialog in:
    • ItwCieCardReaderScreen
    • ItwCieIdLoginScreen
    • ItwSpidIdpLoginScreen
    • ItwIssuanceCredentialPreviewScreen
    • ItwIssuanceEidPreviewScreen

How to test

Check that the dismiss confirmation dialog is displayed correctly in the updated screens.

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 49.99%. Comparing base (bf82569) to head (d43c093).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...es/itwallet/common/hooks/useItwDismissalDialog.tsx 50.00% 3 Missing ⚠️
...ntification/screens/cie/ItwCieCardReaderScreen.tsx 0.00% 2 Missing ⚠️
...entification/screens/cieId/ItwCieIdLoginScreen.tsx 66.66% 1 Missing ⚠️
...ntification/screens/spid/ItwSpidIdpLoginScreen.tsx 0.00% 1 Missing ⚠️
...nce/screens/ItwIssuanceCredentialPreviewScreen.tsx 0.00% 1 Missing ⚠️
...t/issuance/screens/ItwIssuanceEidPreviewScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6641      +/-   ##
==========================================
+ Coverage   49.84%   49.99%   +0.14%     
==========================================
  Files        1541     1544       +3     
  Lines       32154    32168      +14     
  Branches     7239     7290      +51     
==========================================
+ Hits        16028    16081      +53     
+ Misses      16088    16049      -39     
  Partials       38       38              
Files with missing lines Coverage Δ
ts/hooks/useHardwareBackButton.ts 64.70% <ø> (ø)
...entification/screens/cieId/ItwCieIdLoginScreen.tsx 73.68% <66.66%> (ø)
...ntification/screens/spid/ItwSpidIdpLoginScreen.tsx 8.10% <0.00%> (-0.23%) ⬇️
...nce/screens/ItwIssuanceCredentialPreviewScreen.tsx 9.37% <0.00%> (ø)
...t/issuance/screens/ItwIssuanceEidPreviewScreen.tsx 9.37% <0.00%> (+0.28%) ⬆️
...ntification/screens/cie/ItwCieCardReaderScreen.tsx 9.01% <0.00%> (-0.08%) ⬇️
...es/itwallet/common/hooks/useItwDismissalDialog.tsx 55.55% <50.00%> (+38.88%) ⬆️

... and 57 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf82569...d43c093. Read the comment docs.

@mastro993 mastro993 self-assigned this Jan 27, 2025
@mastro993 mastro993 marked this pull request as ready for review January 27, 2025 15:39
Copy link
Contributor

@ale-mazz ale-mazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit dd98d71 Feb 3, 2025
22 checks passed
@mastro993 mastro993 deleted the SIW-1989-add-itw-hw-back-confirmation-dialog branch February 3, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants