-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1989] Add dismiss confirmation dialog to IT Wallet identification flows #6641
Merged
mastro993
merged 9 commits into
master
from
SIW-1989-add-itw-hw-back-confirmation-dialog
Feb 3, 2025
Merged
chore(IT Wallet): [SIW-1989] Add dismiss confirmation dialog to IT Wallet identification flows #6641
mastro993
merged 9 commits into
master
from
SIW-1989-add-itw-hw-back-confirmation-dialog
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
ale-mazz
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the dismiss confirmation dialog in some identification flow screens.
List of changes proposed in this pull request
useHardwareBackButton
inside theuseItwDismissalDialog
to show the dialog also for hardware back buttonsItwCieCardReaderScreen
ItwCieIdLoginScreen
ItwSpidIdpLoginScreen
ItwIssuanceCredentialPreviewScreen
ItwIssuanceEidPreviewScreen
How to test
Check that the dismiss confirmation dialog is displayed correctly in the updated screens.