-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [PE-921] CGN remove legacy and deprecated code #6642
Conversation
this will fix dark mode background color issue
use OperationResultScreenContent, replace old navigator method
this will fix dark mode background color issue
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6642 +/- ##
==========================================
+ Coverage 49.54% 49.61% +0.06%
==========================================
Files 1547 1543 -4
Lines 32179 32119 -60
Branches 7286 7277 -9
==========================================
- Hits 15944 15936 -8
+ Misses 16197 16132 -65
- Partials 38 51 +13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@LeleDallas Just run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Short description
This pull request removes unused CGN components, updates the navigation, and improves the merchant list screen
List of changes proposed in this pull request
CgnMerchantsFilters
,CategoryCheckbox
andDistanceSlider
components as they were unused.TABS
route from theCgnDetailsParamsList
typeonPressShowCgnDiscounts
function to use the new navigation approach and removed unused dispatch actionsLoadingErrorComponent
withOperationResultScreenContent
BaseScreenComponent
withuseHeaderSecondLevel
forCgnMerchantLandingWebview
How to test
Ensure that all CGN functionality works without regressions
Preview
Screen.Recording.2025-01-27.at.16.00.32.mov
Screen.Recording.2025-01-27.at.15.59.50.mov
This PR is also fixing some dark mode background issue