Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [IOCOM-1820] useFimsHistoryResultToast tests #6643

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

forrest57
Copy link
Contributor

Short description

addition of tests for said hook

List of changes proposed in this pull request

  • required tests

How to test

all cases should resolve correctly

Copy link
Contributor

github-actions bot commented Jan 27, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Jan 27, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.69%. Comparing base (8285c9c) to head (5d71545).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6643      +/-   ##
==========================================
+ Coverage   49.60%   49.69%   +0.08%     
==========================================
  Files        1543     1543              
  Lines       32131    32131              
  Branches     7232     7234       +2     
==========================================
+ Hits        15939    15967      +28     
+ Misses      16154    16126      -28     
  Partials       38       38              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8285c9c...5d71545. Read the comment docs.

@forrest57
Copy link
Contributor Author

@Vangaorth comments addressed, LMK!

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants