Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: [IOAPPX-473] Add dark mode support to the ItwCredentialCard component #6645

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 28, 2025

Short description

This PR adds a proper dark mode support to the ItwCredentialCard component.

List of changes proposed in this pull request

  • To get the correct theme color values, convert the borderColorByStatus function to the useBorderColorByStatus hook
  • [extra] Add smooth corners to the wallet cards (iOS only)

Preview

Before After
Simulator Screenshot - iPhone 16 Pro - 2025-01-28 at 10 16 12 Simulator Screenshot - iPhone 16 Pro - 2025-01-28 at 10 14 59

How to test

Launch the app in your local environment, switch to the dark mode and go to the Wallet section of the Design System

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter Dark mode 🌝 IT Wallet labels Jan 28, 2025
@dmnplb dmnplb requested review from ChrisMattew, gispada, freddi301 and a team as code owners January 28, 2025 09:49
Copy link
Contributor

github-actions bot commented Jan 28, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@dmnplb dmnplb changed the title [IOAPPX-473] Add dark mode support to the ItwCredentialCard component style: [IOAPPX-473] Add dark mode support to the ItwCredentialCard component Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 49.55%. Comparing base (47e46f3) to head (62d1944).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...let/common/components/ItwSkeumorphicCard/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6645   +/-   ##
=======================================
  Coverage   49.54%   49.55%           
=======================================
  Files        1547     1547           
  Lines       32179    32183    +4     
  Branches     7286     7289    +3     
=======================================
+ Hits        15944    15947    +3     
+ Misses      16197    16185   -12     
- Partials       38       51   +13     
Files with missing lines Coverage Δ
...s/itwallet/common/components/ItwCredentialCard.tsx 100.00% <100.00%> (ø)
...atures/itwallet/common/utils/itwCredentialUtils.ts 90.90% <100.00%> (+2.02%) ⬆️
...eatures/payments/common/components/PaymentCard.tsx 96.87% <ø> (ø)
...let/common/components/ItwSkeumorphicCard/index.tsx 16.12% <0.00%> (-0.54%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47e46f3...62d1944. Read the comment docs.

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit 8285c9c Jan 28, 2025
22 checks passed
@dmnplb dmnplb deleted the IOAPPX-473-dark-mode-documents branch January 28, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dark mode 🌝 Design System New visual language and reduction of previous UI clutter IT Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants