Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPX-474] Add haptic feedback to the main cards in the Services section #6646

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 28, 2025

Short description

This PR adds the haptic feedback to the main cards visible in the Services section.

List of changes proposed in this pull request

  • Add handleOnPress function to the CardPressableBase

How to test

  1. Launch the app in your testing device
  2. Go to the Services main section
  3. Try to press on main modules at the top of the screen

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Jan 28, 2025
@dmnplb dmnplb requested review from ChrisMattew, gispada, freddi301 and a team as code owners January 28, 2025 09:53
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Jan 28, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@dmnplb dmnplb changed the title [IOAPPX-474] Add haptic feedback to the main cards in the Services section chore: [IOAPPX-474] Add haptic feedback to the main cards in the Services section Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.59%. Comparing base (fd7f4ce) to head (acbfd0e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...s/services/common/components/CardPressableBase.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6646      +/-   ##
==========================================
- Coverage   49.60%   49.59%   -0.01%     
==========================================
  Files        1543     1543              
  Lines       32127    32132       +5     
  Branches     7285     7238      -47     
==========================================
+ Hits        15936    15937       +1     
- Misses      16140    16157      +17     
+ Partials       51       38      -13     
Files with missing lines Coverage Δ
...s/services/common/components/CardPressableBase.tsx 63.63% <20.00%> (-36.37%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd7f4ce...acbfd0e. Read the comment docs.

const handleOnPress = useCallback(
(event: GestureResponderEvent) => {
if (onPress) {
ReactNativeHapticFeedback.trigger("impactLight");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReactNativeHapticFeedback.trigger("impactLight");
ReactNativeHapticFeedback.trigger(HapticFeedbackTypes.impactLight);

@dmnplb dmnplb added this pull request to the merge queue Jan 28, 2025
Merged via the queue into master with commit c36ad2f Jan 28, 2025
22 checks passed
@dmnplb dmnplb deleted the IOAPPX-474-haptic-feedback-services-cards branch January 28, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants