Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [PE-786] CGN update support fields optional #6647

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Jan 28, 2025

Short description

Warning

To test it you need this pagopa/io-dev-api-server#460

This pull request includes updates to a script and a navigation route in the codebase

List of changes proposed in this pull request

  • Updated IO_BACKEND_VERSION from v16.7.3-RELEASE to v16.7.4-RELEASE
  • Changed the navigation route in the onPress function from a string literal to a constant defined in CGN_ROUTES

How to test

Ensure that CGN works without regression

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.68%. Comparing base (32b1437) to head (12497a7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...n/screens/merchants/CgnMerchantsListByCategory.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6647   +/-   ##
=======================================
  Coverage   49.68%   49.68%           
=======================================
  Files        1543     1543           
  Lines       32136    32136           
  Branches     7282     7239   -43     
=======================================
  Hits        15968    15968           
+ Misses      16130    16129    -1     
- Partials       38       39    +1     
Files with missing lines Coverage Δ
...n/screens/merchants/CgnMerchantsListByCategory.tsx 1.53% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b1437...12497a7. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants