chore: [IOPAE-1744,IOPAE-1749] Remove transparent header to solve accessibility problems #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelloste
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6692 +/- ##
==========================================
+ Coverage 46.15% 49.49% +3.33%
==========================================
Files 1424 1451 +27
Lines 30186 30820 +634
Branches 6768 6939 +171
==========================================
+ Hits 13933 15255 +1322
+ Misses 16223 15531 -692
- Partials 30 34 +4
... and 127 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dmnplb
approved these changes
Feb 17, 2025
giuseppedipinto
approved these changes
Feb 17, 2025
adelloste
deleted the
IOPAE-1744-IOPAE-1749-accessibility-improvements
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ovements (#6698) This PR depends on #6692 ## Short description This PR fixes minor accessibility issues ## List of changes proposed in this pull request - Removed unnecessary `accessibilityLabel` prop - Added `accessibilityHint` prop to FiscalCode ## How to test Enable the screen reader and navigate to the service details screen. Check that the metadata are announced correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR removes the transparent header to solve accessibility problems
details
file.mp4
List of changes proposed in this pull request
transparentprop fromuseHeaderSecondLevelServiceHeader: now title label is announced as a headerServiceActionsPropsgetActionsPropsfunction fromServiceDetailsScreenHow to test
Using the screen reader make sure the header is accessible and actions are announced correctly