-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPLT-951] Add the new typeface selection banner to the Settings
screen
#6695
base: IOAPPX-453-add-new-appearance-page
Are you sure you want to change the base?
feat: [IOPLT-951] Add the new typeface selection banner to the Settings
screen
#6695
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Co-authored-by: Jacopo Pompilii <[email protected]>
…ion. Delete unsed setShowProfileBanner action. Fix tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## IOAPPX-453-add-new-appearance-page #6695 +/- ##
======================================================================
+ Coverage 50.07% 50.09% +0.02%
======================================================================
Files 1558 1561 +3
Lines 32470 32486 +16
Branches 7299 7354 +55
======================================================================
+ Hits 16260 16275 +15
+ Misses 16171 16159 -12
- Partials 39 52 +13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hi team IO-Com (@Vangaorth and @forrest57 ) ✨ and team A&I (@shadowsheep1 and @ChrisMattew ) 🫶🏼 |
…typeface-banner-settings
Caution
This PR depends on:
Appearance
profile screen #6573Short description
This PR adds the new typeface selection banner to the Settings screen.
List of changes proposed in this pull request
showProfileBanner
ts/features/profileSettings/store/selectors/index.ts
tots/features/appearanceSettings/store/selectors/index.ts
Preview
show_new_banner_selectors_persistence_720.mov
typeface-selection-settings.mp4
Author(s)
@Ladirico @dmnplb
How to test
Run the application and test if everything works as you can see from the preview section