Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPLT-951] Add the new typeface selection banner to the Settings screen #6695

Open
wants to merge 9 commits into
base: IOAPPX-453-add-new-appearance-page
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Feb 6, 2025

Short description

This PR adds the new typeface selection banner to the Settings screen.

List of changes proposed in this pull request

  • Add new selector for appearance banner
  • Delete unsed banner and selector showProfileBanner
  • Move logic to show banner from ts/features/profileSettings/store/selectors/index.ts to ts/features/appearanceSettings/store/selectors/index.ts
  • Updated configurations for persistence
  • Add the new locale strings for the new banner

Preview

Working of the selector Flow
show_new_banner_selectors_persistence_720.mov
typeface-selection-settings.mp4

Author(s)

@Ladirico @dmnplb

How to test

Run the application and test if everything works as you can see from the preview section

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Feb 6, 2025
dmnplb and others added 2 commits February 6, 2025 17:06
Co-authored-by: Jacopo Pompilii <[email protected]>
…ion. Delete unsed setShowProfileBanner action. Fix tests
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.09%. Comparing base (6556e60) to head (f78a8e4).

Files with missing lines Patch % Lines
...s/features/profileSettings/store/reducers/index.ts 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                          Coverage Diff                           @@
##           IOAPPX-453-add-new-appearance-page    #6695      +/-   ##
======================================================================
+ Coverage                               50.07%   50.09%   +0.02%     
======================================================================
  Files                                    1558     1561       +3     
  Lines                                   32470    32486      +16     
  Branches                                 7299     7354      +55     
======================================================================
+ Hits                                    16260    16275      +15     
+ Misses                                  16171    16159      -12     
- Partials                                   39       52      +13     
Files with missing lines Coverage Δ
...features/appearanceSettings/store/actions/index.ts 100.00% <100.00%> (ø)
...eatures/appearanceSettings/store/reducers/index.ts 100.00% <100.00%> (ø)
...atures/appearanceSettings/store/selectors/index.ts 100.00% <100.00%> (ø)
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/features/profileSettings/store/actions/index.ts 100.00% <ø> (ø)
.../features/profileSettings/store/selectors/index.ts 100.00% <ø> (ø)
ts/screens/profile/ProfileMainScreenTopBanner.tsx 100.00% <100.00%> (ø)
ts/store/reducers/index.ts 40.74% <ø> (ø)
...s/features/profileSettings/store/reducers/index.ts 71.42% <25.00%> (-3.58%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6556e60...f78a8e4. Read the comment docs.

@Ladirico
Copy link
Contributor

Ladirico commented Feb 7, 2025

Hi team IO-Com (@Vangaorth and @forrest57 ) ✨ and team A&I (@shadowsheep1 and @ChrisMattew ) 🫶🏼
I would like you to check this PR because some logics have been changed as well, so I would like a check from one dev by team please
Thanks so much 🚀

@Ladirico Ladirico marked this pull request as ready for review February 7, 2025 16:03
@Ladirico Ladirico requested review from gispada, freddi301 and a team as code owners February 7, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System New visual language and reduction of previous UI clutter dont-merge ✋
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants