Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOPAE-1758,IOPAE-1759,IOPAE-1761,IOPAE-1762] Accessibility improvements #6698

Merged
merged 11 commits into from
Feb 18, 2025

Conversation

adelloste
Copy link
Member

This PR depends on #6692

Short description

This PR fixes minor accessibility issues

List of changes proposed in this pull request

  • Removed unnecessary accessibilityLabel prop
  • Added accessibilityHint prop to FiscalCode

How to test

Enable the screen reader and navigate to the service details screen. Check that the metadata are announced correctly.

@adelloste adelloste added a11y Activities related to accessibility IO-Enti e Servizi IO - Enti e Servizi labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@adelloste adelloste changed the title [IOPAE-1758,IOPAE-1759,IOPAE-1761,IOPAE-1762] Accessibility improvements fix: [IOPAE-1758,IOPAE-1759,IOPAE-1761,IOPAE-1762] Accessibility improvements Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.53%. Comparing base (3151da2) to head (3e47ea8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ices/details/components/ServiceDetailsMetadata.tsx 0.00% 4 Missing ⚠️
.../institution/screens/InstitutionServicesScreen.tsx 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3151da2) and HEAD (3e47ea8). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (3151da2) HEAD (3e47ea8)
8 5
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6698      +/-   ##
==========================================
- Coverage   47.68%   41.53%   -6.15%     
==========================================
  Files        1445     1408      -37     
  Lines       30639    29840     -799     
  Branches     6938     6681     -257     
==========================================
- Hits        14609    12393    -2216     
- Misses      15994    17418    +1424     
+ Partials       36       29       -7     
Files with missing lines Coverage Δ
.../institution/screens/InstitutionServicesScreen.tsx 78.94% <66.66%> (+4.37%) ⬆️
...ices/details/components/ServiceDetailsMetadata.tsx 2.77% <0.00%> (ø)

... and 214 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3151da2...3e47ea8. Read the comment docs.

Copy link

dpulls bot commented Feb 17, 2025

🎉 All dependencies have been resolved !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Enti e Servizi IO - Enti e Servizi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants