Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [PE-965] CGN Swipe back gesture to root stack navigator #6708

Merged
merged 9 commits into from
Feb 17, 2025

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Feb 12, 2025

Short description

This PR fixes the swipe-back gesture inside the CGN screens, causing incorrect navigation directly to the root navigator instead of the previous screen in the stack.

List of changes proposed in this pull request

  • Created a custom hook useDisableRootNavigatorGesture that disables the root navigator swipe back gesture when invoked.

Preview

Before After
before.MP4
after.mov

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.25%. Comparing base (4359b93) to head (8e342f5).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6708      +/-   ##
==========================================
+ Coverage   50.11%   50.25%   +0.13%     
==========================================
  Files        1557     1558       +1     
  Lines       32468    32475       +7     
  Branches     7356     7359       +3     
==========================================
+ Hits        16272    16320      +48     
+ Misses      16144    16114      -30     
+ Partials       52       41      -11     
Files with missing lines Coverage Δ
...bonus/cgn/hooks/useDisableRootNavigatorGesture.tsx 100.00% <100.00%> (ø)
...erchants/CgnMerchantsCategoriesSelectionScreen.tsx 75.00% <100.00%> (+48.68%) ⬆️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4359b93...8e342f5. Read the comment docs.

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think to add coverage for missing test in this development?

@Hantex9 Hantex9 added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit f969b17 Feb 17, 2025
22 checks passed
@Hantex9 Hantex9 deleted the PE-965-fix-cgn-navigation branch February 17, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants