Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-2003] ITW auth level tracking #6710

Merged
merged 15 commits into from
Feb 17, 2025
Merged

fix(IT Wallet): [SIW-2003] ITW auth level tracking #6710

merged 15 commits into from
Feb 17, 2025

Conversation

ale-mazz
Copy link
Contributor

Short description

This PR adds a new field in the preferences itw store that contains the auth level used when a WI is requested.
It also handle the updates related to that field and the correct tracking with Mixpanel

List of changes proposed in this pull request

  • Added a new field in the preferences itw store called authLevel that can be undefined, L2 or L3
  • Stored the correct auth level when requesting the WI.
  • Handled the store field reset when revocating the WI.
  • Updated mixpanel tracking.

How to test

Verify that the store is filled with the L2 value when updating from a previous version.
Try now to revoke the WI and request it again using an L3 level (CIE+PIN). Check redux if it is correct.
Verify that mixpanel receives the correct information.

@ale-mazz ale-mazz changed the title feat(IT Wallet): [SIW-2003] Fix ITW auth level tracking fix(IT Wallet): [SIW-2003] ITW auth level tracking Feb 12, 2025
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@ale-mazz ale-mazz marked this pull request as ready for review February 12, 2025 14:07
@ale-mazz ale-mazz self-assigned this Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 49.99%. Comparing base (6e60dc2) to head (8020fb8).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/itwallet/analytics/index.ts 25.00% 6 Missing ⚠️
...s/features/itwallet/common/store/reducers/index.ts 14.28% 6 Missing ⚠️
...t/issuance/screens/ItwIssuanceEidPreviewScreen.tsx 0.00% 5 Missing ⚠️
ts/features/itwallet/machine/eid/actions.ts 0.00% 3 Missing ⚠️
ts/mixpanelConfig/profileProperties.ts 0.00% 2 Missing ⚠️
ts/mixpanelConfig/superProperties.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6710      +/-   ##
==========================================
+ Coverage   43.91%   49.99%   +6.07%     
==========================================
  Files        1417     1557     +140     
  Lines       30090    32462    +2372     
  Branches     6749     7350     +601     
==========================================
+ Hits        13213    16228    +3015     
+ Misses      16847    16183     -664     
- Partials       30       51      +21     
Files with missing lines Coverage Δ
...tures/itwallet/common/store/actions/preferences.ts 100.00% <100.00%> (ø)
...ures/itwallet/common/store/reducers/preferences.ts 87.50% <100.00%> (+46.59%) ⬆️
...res/itwallet/common/store/selectors/preferences.ts 100.00% <100.00%> (ø)
ts/features/itwallet/machine/eid/context.ts 100.00% <ø> (ø)
ts/features/itwallet/machine/eid/machine.ts 94.44% <ø> (ø)
ts/mixpanelConfig/profileProperties.ts 24.00% <0.00%> (ø)
ts/mixpanelConfig/superProperties.ts 22.72% <0.00%> (ø)
ts/features/itwallet/machine/eid/actions.ts 1.47% <0.00%> (-0.03%) ⬇️
...t/issuance/screens/ItwIssuanceEidPreviewScreen.tsx 8.82% <0.00%> (-0.56%) ⬇️
ts/features/itwallet/analytics/index.ts 33.68% <25.00%> (+6.80%) ⬆️
... and 1 more

... and 353 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e60dc2...8020fb8. Read the comment docs.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ale-mazz ale-mazz added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit ca154f3 Feb 17, 2025
22 checks passed
@ale-mazz ale-mazz deleted the siw-2003 branch February 17, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants