-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-2003] ITW auth level tracking #6710
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6710 +/- ##
==========================================
+ Coverage 43.91% 49.99% +6.07%
==========================================
Files 1417 1557 +140
Lines 30090 32462 +2372
Branches 6749 7350 +601
==========================================
+ Hits 13213 16228 +3015
+ Misses 16847 16183 -664
- Partials 30 51 +21
... and 353 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Gianluca Spada <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR adds a new field in the
preferences
itw store that contains the auth level used when a WI is requested.It also handle the updates related to that field and the correct tracking with Mixpanel
List of changes proposed in this pull request
preferences
itw store called authLevel that can beundefined
,L2
orL3
How to test
Verify that the store is filled with the
L2
value when updating from a previous version.Try now to revoke the WI and request it again using an
L3
level (CIE+PIN). Check redux if it is correct.Verify that mixpanel receives the correct information.