Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [IOBP-1204] Add IUV to label #6713

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request updates the localization for noticeCode to include the IUV text

List of changes proposed in this pull request

  • Updated the noticeCode translation to Codice avviso/IUV and added a new entry for noticeCodeAccessible with the value Codice avviso/Identificativo Univoco Versamento
  • Apply noticeCodeAccessible text for the accessibilityLabel

How to test

Ensure that label text in PAYMENT_RECEIPT_CART_ITEM_DETAILS now includes /IUV

Preview

Screenshot 2025-02-13 at 12 59 50

@LeleDallas LeleDallas added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Feb 13, 2025
@LeleDallas LeleDallas self-assigned this Feb 13, 2025
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.00%. Comparing base (df85e81) to head (40c7cd8).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6713   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files        1557     1557           
  Lines       32445    32445           
  Branches     7345     7342    -3     
=======================================
  Hits        16223    16223           
- Misses      16171    16182   +11     
+ Partials       51       40   -11     
Files with missing lines Coverage Δ
.../receipts/screens/ReceiptCartItemDetailsScreen.tsx 4.16% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df85e81...40c7cd8. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeleDallas LeleDallas added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit 6e60dc2 Feb 13, 2025
22 checks passed
@LeleDallas LeleDallas deleted the IOBP-1204-add-iuv-text branch February 13, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants