Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [IOCOM-1830] fimsHistoryNonEmptyContent tests #6715

Merged

Conversation

forrest57
Copy link
Contributor

Short description

tests for said component

List of changes proposed in this pull request

for fimsHistoryNonEmptyContent:

  • required tests
  • required mocks
  • snapshots
  • updated the jestSetup to include its required setup for testing
  • removal of deprecated component usage in favor of its updated version
  • addition of testIds where necessary
  • refactor of typing in order to better test
  • refactor of selector usage to include new, more direct selector that has already been implemented

How to test

automated tests should all pass correctly, also the "export" button should still work as intended.

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 13, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.09%. Comparing base (84a1f99) to head (9be76ae).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6715      +/-   ##
==========================================
+ Coverage   50.04%   50.09%   +0.05%     
==========================================
  Files        1557     1557              
  Lines       32446    32445       -1     
  Branches     7299     7345      +46     
==========================================
+ Hits        16236    16254      +18     
+ Misses      16171    16140      -31     
- Partials       39       51      +12     
Files with missing lines Coverage Δ
.../history/components/FimsHistoryNonEmptyContent.tsx 100.00% <100.00%> (+94.11%) ⬆️
ts/features/fims/history/store/reducer/index.ts 100.00% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a1f99...9be76ae. Read the comment docs.

…ontent' of https://github.com/pagopa/io-app into IOCOM-1830-app-test-automatici-fims-history-non-empty-content
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit fc52b1d Feb 14, 2025
21 of 22 checks passed
@forrest57 forrest57 deleted the IOCOM-1830-app-test-automatici-fims-history-non-empty-content branch February 14, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants