Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOCOM-2095] Preconditions scroll #6718

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR fixes the preconditions' content going underneath the Footer button, when scrolling

iOS Android
ScreeniOS ScreenAndroid

List of changes proposed in this pull request

  • Computation of FooterActions height
  • Forwarding of such value to the preconditions' content
  • Extra view on the preconditions' content to compensate for the extra height

How to test

Using the io-dev-api-server, generate some SEND message and change the precondition content to be a very long text. Check that both old markdown and IOMarkdown are able to scroll to the bottom of the text.

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 14, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.23%. Comparing base (90cfeb1) to head (fcc1b5c).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
.../messages/components/Home/PreconditionsContent.tsx 77.77% 1 Missing and 1 partial ⚠️
...s/messages/components/Home/PreconditionsFooter.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6718      +/-   ##
==========================================
- Coverage   50.28%   50.23%   -0.05%     
==========================================
  Files        1558     1556       -2     
  Lines       32477    32416      -61     
  Branches     7363     7333      -30     
==========================================
- Hits        16330    16285      -45     
+ Misses      16094    16091       -3     
+ Partials       53       40      -13     
Files with missing lines Coverage Δ
.../history/components/FimsHistoryNonEmptyContent.tsx 100.00% <ø> (ø)
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 33.33% <ø> (ø)
...eens/ItwPresentationCredentialAttachmentScreen.tsx 12.12% <ø> (ø)
...eatures/messages/components/Home/Preconditions.tsx 100.00% <100.00%> (ø)
...payments/receipts/screens/ReceiptPreviewScreen.tsx 4.34% <ø> (ø)
...s/messages/components/Home/PreconditionsFooter.tsx 97.05% <0.00%> (-2.95%) ⬇️
.../messages/components/Home/PreconditionsContent.tsx 78.57% <77.77%> (-0.92%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0578ec7...fcc1b5c. Read the comment docs.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth added this pull request to the merge queue Feb 20, 2025
Merged via the queue into master with commit 6d90444 Feb 20, 2025
22 checks passed
@Vangaorth Vangaorth deleted the IOCOM-2095_preconditionsScroll branch February 20, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants