Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IDPay): [IOBP-1205] Removed the missing configuration alert for EXPENSE initiatives #6719

Merged

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Feb 14, 2025

Short description

This PR removes the missing configuration alert for initiatives of type EXPENSE

List of changes proposed in this pull request

  • Added tests to check if the alert should be shown or not;
  • Removed the component MissingConfigurationAlert from the content render of IDPay details screen;

How to test

  • Open an IDPay expense initiative that has the status of value NOT_REFUNDABLE_ONLY_INSTRUMENT;
  • Check that there isn't any alert showing a message;
  • Double-check that the other initiatives of type REFUND, if status is NOT_REFUNDABLE_ONLY_INSTRUMENT, should show the correct alert.

Preview

Before After

@Hantex9 Hantex9 added IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti labels Feb 14, 2025
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@Hantex9 Hantex9 changed the title chore(IDPay): Removed the missing configuration alert for EXPENSE initiatives chore(IDPay): [IOBP-1205] Removed the missing configuration alert for EXPENSE initiatives Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.04%. Comparing base (a5d2865) to head (a7ba71c).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6719      +/-   ##
==========================================
+ Coverage   45.73%   50.04%   +4.30%     
==========================================
  Files        1551     1557       +6     
  Lines       32379    32446      +67     
  Branches     7332     7297      -35     
==========================================
+ Hits        14809    16236    +1427     
+ Misses      17534    16171    -1363     
- Partials       36       39       +3     
Files with missing lines Coverage Δ
...y/details/components/MissingConfigurationAlert.tsx 92.30% <ø> (+84.61%) ⬆️
...y/details/screens/IdPayInitiativeDetailsScreen.tsx 78.00% <ø> (+76.00%) ⬆️

... and 130 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d2865...a7ba71c. Read the comment docs.

@Hantex9 Hantex9 added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit 6099525 Feb 14, 2025
23 of 24 checks passed
@Hantex9 Hantex9 deleted the IOBP-1205-disable-missing-config-alert-for-expense-idpay branch February 14, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants