-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOPID-2690] Support back navigation from CieIdLoginScreen
and CieConsentDataUsageScreen
#6721
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
This reverts commit bc549b6.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6721 +/- ##
==========================================
+ Coverage 46.15% 50.13% +3.97%
==========================================
Files 1424 1557 +133
Lines 30186 32470 +2284
Branches 6768 7301 +533
==========================================
+ Hits 13933 16279 +2346
+ Misses 16223 16152 -71
- Partials 30 39 +9
... and 292 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CieIdLoginScreen
and CieConsentDataUsageScreen
CieIdLoginScreen
and CieConsentDataUsageScreen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR adds the possibility to go back from
CieIdLoginWebView
andCieConsentDataUsageScreen
Details
Android
-.cie.mp4
-.cieid.mp4
iOS
-.cie.MP4
-.cieid.MP4
List of changes proposed in this pull request
ts/features/cieLogin/components/CieIdLoginWebView.tsx
: Added theuseOnboardingAbortAlert
hook and updated theheaderProps
to use theshowAlert
method from the hook when navigating back. [1] [2]ts/screens/authentication/cie/CieConsentDataUsageScreen.tsx
: Replaced theuseHardwareBackButton
hook with theuseHeaderSecondLevel
hook, and updated theshowAlert
method to include navigation callback. [1] [2]ts/utils/hooks/useOnboardingAbortAlert.ts
: Modified theshowAlert
method to accept an optional callback and dispatch theabortOnboarding
action if no callback is provided. [1] [2] [3]ts/utils/__tests__/hooks/useOnboardingAbortAlert.test.ts
: Added tests to verify the alert functionality and the dispatching of theabortOnboarding
action.ts/navigation/AuthenticationNavigator.tsx
: Enabled the header for theCieConsentDataUsageScreen
component.How to test
Try to login with CIE+PIN and CieID and check if, in the page where you need to accept the data usage, there's the
goBack
button in the navigation header and test it (Take the "Details" demo video as an example).