Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPID-2690] Support back navigation from CieIdLoginScreen and CieConsentDataUsageScreen #6721

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Feb 14, 2025

Short description

This PR adds the possibility to go back from CieIdLoginWebView and CieConsentDataUsageScreen

Details

Android

Cie CieID
-.cie.mp4
-.cieid.mp4

iOS

Cie CieID
-.cie.MP4
-.cieid.MP4

List of changes proposed in this pull request

How to test

Try to login with CIE+PIN and CieID and check if, in the page where you need to accept the data usage, there's the goBack button in the navigation header and test it (Take the "Details" demo video as an example).

Copy link
Contributor

github-actions bot commented Feb 14, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.13%. Comparing base (b1cc73f) to head (c83c735).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...s/authentication/cie/CieConsentDataUsageScreen.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6721      +/-   ##
==========================================
+ Coverage   46.15%   50.13%   +3.97%     
==========================================
  Files        1424     1557     +133     
  Lines       30186    32470    +2284     
  Branches     6768     7301     +533     
==========================================
+ Hits        13933    16279    +2346     
+ Misses      16223    16152      -71     
- Partials       30       39       +9     
Files with missing lines Coverage Δ
...features/cieLogin/components/CieIdLoginWebView.tsx 64.81% <100.00%> (+57.33%) ⬆️
ts/navigation/AuthenticationNavigator.tsx 40.00% <ø> (ø)
ts/utils/hooks/useOnboardingAbortAlert.ts 100.00% <100.00%> (+42.85%) ⬆️
...s/authentication/cie/CieConsentDataUsageScreen.tsx 3.63% <0.00%> (+0.12%) ⬆️

... and 292 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cc73f...c83c735. Read the comment docs.

@shadowsheep1 shadowsheep1 changed the title chore: [IOPID-2690] Add the possibility to go back from CieIdLoginScreen and CieConsentDataUsageScreen chore: [IOPID-2690] Support back navigation from CieIdLoginScreen and CieConsentDataUsageScreen Feb 17, 2025
Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants