Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOCOM-2097] Special link support removed from IOMarkdown on messages and services #6722

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR removes (broken) support for non https links on IOMarkdown, on messages and services

Simulator.Screen.Recording.-.iPhone.16.-.2025-02-14.at.17.48.51_mid.mp4

List of changes proposed in this pull request

  • Link filtering to only work for ioit and https links

How to test

Using the io-dev-api-server, check that:

  • ioit links work
  • https links work
  • any other type of link does not work

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 14, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.11%. Comparing base (ca154f3) to head (df24a16).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6722      +/-   ##
==========================================
+ Coverage   50.08%   50.11%   +0.02%     
==========================================
  Files        1557     1557              
  Lines       32462    32467       +5     
  Branches     7302     7349      +47     
==========================================
+ Hits        16259    16271      +12     
+ Misses      16163    16145      -18     
- Partials       40       51      +11     
Files with missing lines Coverage Δ
ts/components/ui/Markdown/handlers/link.ts 70.00% <100.00%> (+2.14%) ⬆️
...tures/common/components/IOMarkdown/customRules.tsx 50.00% <100.00%> (+30.95%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca154f3...df24a16. Read the comment docs.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit b1cc73f Feb 17, 2025
22 checks passed
@Vangaorth Vangaorth deleted the IOCOM-2097_noSpecialLinks branch February 17, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants