-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IT Wallet): [SIW-1961] Handle invalid payload in deeplink for Remote presentation #6724
Merged
mastro993
merged 49 commits into
master
from
SIW-1961-deeplink-invalid-payload-failure-screen
Feb 20, 2025
Merged
feat(IT Wallet): [SIW-1961] Handle invalid payload in deeplink for Remote presentation #6724
mastro993
merged 49 commits into
master
from
SIW-1961-deeplink-invalid-payload-failure-screen
Feb 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-remote-presentation-same-device
…sentation-same-device
…sentation-same-device
… presentation flow
…sentation-same-device
…nvalid-payload-failure-screen
mastro993
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR handles the view for an invalid payload in the deeplink during the remote presentation flow
Warning
This PR depends on #6689
List of changes proposed in this pull request
ItwRemoteDeepLinkFailureScreen
ItwFailureTypes.ts
, specifically to manage errors for thesupport bottom sheet
, outside the state machine flows. This type of error is intended to be global for ITWallet, and the flow to which it belongs must be specified in the codeZendeskSubcategoryValue
enum inuseItwFailureSupportModal
, representing possible Zendesk subcategory values for opening a support ticket. This is passed as a prop when usinguseItwFailureSupportModal
How to test
To test the changes, use an invalid deeplink (e.g., https://continua.io.pagopa.it/itw/auth?client_id=abc123x) and verify that the support bottom sheet appears.
Note
I don't have the possibility to use deeplinks during development. I use the same deeplink flow but by scanning the QR code instead
Screen.Recording.2025-02-20.at.10.17.25.mov