Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-1179] a11y banner focus order #6725

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request updates the @pagopa/io-app-design-system to solve the accessibility focus order of the Banner component

List of changes proposed in this pull request

  • Updated the @pagopa/io-app-design-system package from version 4.5.5 to 4.5.6
  • Removed the unused SwitchLabel
  • Removed the unnecessary fragment tags around the AnimatedMessageCheckboxShowroom component

How to test

  • Using a real device 📱, check the Banner in the Pagamenti section
  • Turn on the TalkBack accessibility tool
  • Ensure that when navigating with the Tab and Shift + Tab keys, the switch logic for the Banner component correctly moves focus (Text -> CTA -> Close Icon)

Preview

Screen.Recording.2025-02-17.at.17.00.22.mov

@LeleDallas LeleDallas added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Feb 17, 2025
@LeleDallas LeleDallas self-assigned this Feb 17, 2025
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.11%. Comparing base (4359b93) to head (cfcfeca).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6725   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files        1557     1557           
  Lines       32468    32466    -2     
  Branches     7356     7360    +4     
=======================================
- Hits        16272    16271    -1     
+ Misses      16144    16143    -1     
  Partials       52       52           
Files with missing lines Coverage Δ
ts/features/design-system/core/DSSelection.tsx 36.84% <ø> (-0.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4359b93...cfcfeca. Read the comment docs.

@LeleDallas LeleDallas added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit 29718a3 Feb 17, 2025
22 checks passed
@LeleDallas LeleDallas deleted the IOBP-1179-a11y-banner-focus-order branch February 17, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants