Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [PE-937] a11y on CgnCard expiry date #6726

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Feb 17, 2025

Short description

This PR fixes the a11y text on the expiry date of the CgnCard component, replacing it with more accessible text that contains the full month and full year.

List of changes proposed in this pull request

  • Formatted the accessibilityLabel with the full month and full year in order to be more accessible.

How to test

Inside the wallet home screen, open the SR on your device and check that the CGN validity is more accessible with full month and full year as values.

@Hantex9 Hantex9 added a11y Activities related to accessibility Carta Giovani Nazionale IO-Bonus e pagamenti IO - Bonus e pagamenti labels Feb 17, 2025
Copy link
Contributor

github-actions bot commented Feb 17, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.11%. Comparing base (4359b93) to head (f086476).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/bonus/cgn/components/CgnCard.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6726   +/-   ##
=======================================
  Coverage   50.11%   50.11%           
=======================================
  Files        1557     1557           
  Lines       32468    32471    +3     
  Branches     7356     7359    +3     
=======================================
+ Hits        16272    16274    +2     
- Misses      16144    16158   +14     
+ Partials       52       39   -13     
Files with missing lines Coverage Δ
ts/features/bonus/cgn/components/CgnCard.tsx 86.66% <66.66%> (-5.00%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4359b93...f086476. Read the comment docs.

@Hantex9 Hantex9 added this pull request to the merge queue Feb 17, 2025
Merged via the queue into master with commit 1de394f Feb 17, 2025
22 checks passed
@Hantex9 Hantex9 deleted the PE-937-fix-accessibility-expire-date-cgn-card branch February 17, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility Carta Giovani Nazionale IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants