-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [PE-937] a11y on CgnCard
expiry date
#6726
fix: [PE-937] a11y on CgnCard
expiry date
#6726
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6726 +/- ##
=======================================
Coverage 50.11% 50.11%
=======================================
Files 1557 1557
Lines 32468 32471 +3
Branches 7356 7359 +3
=======================================
+ Hits 16272 16274 +2
- Misses 16144 16158 +14
+ Partials 52 39 -13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Short description
This PR fixes the a11y text on the expiry date of the CgnCard component, replacing it with more accessible text that contains the full month and full year.
List of changes proposed in this pull request
How to test
Inside the wallet home screen, open the SR on your device and check that the CGN validity is more accessible with full month and full year as values.