-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-2012] Notify the user 30 days before credential expiration #6727
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6727 +/- ##
=======================================
Coverage 50.27% 50.27%
=======================================
Files 1558 1558
Lines 32479 32480 +1
Branches 7310 7362 +52
=======================================
+ Hits 16329 16330 +1
+ Misses 16109 16096 -13
- Partials 41 54 +13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR increases the notification period of expiring credentials to 30 days.
List of changes proposed in this pull request
getCredentialStatus
How to test
Use credentials that are about to expire or mock the
expiry_date
claim.