Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-2012] Notify the user 30 days before credential expiration #6727

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Feb 18, 2025

Short description

This PR increases the notification period of expiring credentials to 30 days.

List of changes proposed in this pull request

  • Increased default value to 30 in getCredentialStatus

How to test

Use credentials that are about to expire or mock the expiry_date claim.

Copy link
Contributor

github-actions bot commented Feb 18, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.27%. Comparing base (a676e00) to head (10a3292).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6727   +/-   ##
=======================================
  Coverage   50.27%   50.27%           
=======================================
  Files        1558     1558           
  Lines       32479    32480    +1     
  Branches     7310     7362   +52     
=======================================
+ Hits        16329    16330    +1     
+ Misses      16109    16096   -13     
- Partials       41       54   +13     
Files with missing lines Coverage Δ
.../itwallet/common/utils/itwCredentialStatusUtils.ts 77.77% <100.00%> (+0.63%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a676e00...10a3292. Read the comment docs.

@gispada gispada marked this pull request as ready for review February 18, 2025 09:17
@gispada gispada requested review from ChrisMattew, freddi301 and a team as code owners February 18, 2025 09:17
Copy link
Collaborator

@RiccardoMolinari95 RiccardoMolinari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 added this pull request to the merge queue Feb 20, 2025
Merged via the queue into master with commit 4532159 Feb 20, 2025
22 checks passed
@mastro993 mastro993 deleted the SIW-2012-30-days-expiring branch February 20, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants