Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOPID-2720] FAQ Banner educational for Zendesk subcategories #466

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Feb 13, 2025

Important

Depends on this PR on io-services-metadata

Short description

This PR updates the content_specs url in the package.json and allows to test the bannerEducational config in the local environment for the subCategory accesso_a_io in this PR

List of changes proposed in this pull request

  • Updated the ./generated/definitions/content url source in the scripts/generate-api-models.sh file.
  • Added the bannerEducational for the accesso_a_io category's subcategories in the assets/assistanceTools/zendesk.json config file

How to test

Follow the instructions described in this PR

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.92%. Comparing base (ea04811) to head (fc38c3f).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   63.90%   63.92%   +0.01%     
==========================================
  Files         166      164       -2     
  Lines        5433     5341      -92     
  Branches      750      723      -27     
==========================================
- Hits         3472     3414      -58     
+ Misses       1960     1783     -177     
- Partials        1      144     +143     

see 43 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7b446...fc38c3f. Read the comment docs.

@ChrisMattew ChrisMattew added dont-merge ✋🏼 IO-A&I IO - Autenticazione e Identità labels Feb 13, 2025
@ChrisMattew ChrisMattew marked this pull request as ready for review February 13, 2025 15:33
@ChrisMattew ChrisMattew requested review from gispada, freddi301 and a team as code owners February 13, 2025 15:33
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ladirico Ladirico merged commit 151b9a6 into master Feb 19, 2025
6 checks passed
@Ladirico Ladirico deleted the IOPID-2720-io-login-zendesk-faq-banner branch February 19, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge ✋🏼 IO-A&I IO - Autenticazione e Identità
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants