Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back "v" in order for the release to be found. #943

Closed
wants to merge 2 commits into from

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Jun 12, 2024

Summary

This PR adds the "v" character in front of the release version, as otherwise, it is unable to find and publish it. Specifically on the below actions, the publish draft release action fails due to the "v" character being removed in order to do the ordering. Adding it back manages to find and publish the draft release.

Use Cases

Related issues to close after

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner June 12, 2024 09:30
@sophiewigmore
Copy link
Member

hi @pacostas, sorry for the bug I introduced! I already fixed this in #944 so I'm going to close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants