Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React version check to support 18+ in Portal #7137

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kmpeeduwee
Copy link

Fixes #0000

Checklist

  • Includes tests

Changes proposed in this pull request:

  • Update the Portal component to avoid using the old context API.
  • Replace isReact18 function with isReact18OrHigher to ensure compatibility with React 19.
  • Ensure that the new context API is used in React versions 18 and above, avoiding legacy context usage.

Reviewers should focus on:

  • Correctness of the version-checking logic in isReact18OrHigher.
  • Proper integration of the new context API in the Portal component.
  • Compatibility of changes with React 19 and backwards compatibility with React 18.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @kmpeeduwee! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Dec 30, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Update React version check to support 18+ in Portal

Check the box to generate changelog(s)

  • Generate changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants