Feature/use path to find executables #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwright
force-pushed
the
feature/use-path-to-find-executables
branch
from
82f4199 to
d3390be
Compare
This searches through the path variable's directories for the docker commands, instead of looking in predetermined OS-specific locations or requiring new environmental variables to be set. This also renames DockerCommandLocations to DockerCommandLocator, which better reflects what it is.
samwright
force-pushed
the
feature/use-path-to-find-executables
branch
from
d3390be to
195d9af
Compare
|
@samwright I've pulled these changes into #175 to include the other PR that was open for similar functionality. Sadly it's more complicated that what you've got here, but Docker for Mac installs into a location that isn't on the path when running the tests through Eclipse on a Mac and the environment variable overrides are needed because we install an alternative (more recent) copy of docker-compose as part of CI and need a way to specify that. I'm going to close this PR out in favour of the linked one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This searches through the path variable's directories for the docker
commands, instead of looking in predetermined OS-specific locations or
requiring new environmental variables to be set.
This also renames DockerCommandLocations to DockerCommandLocator, which better
reflects what it is
It also fixes the findbugs excludeFilter.xml file so the bugs to ignore for test classes are actually ignored for the test classes.